Apply suggestions from code review

Co-authored-by: Matthias Diester <[email protected]>

Author: SaschaSchwarze0

cmd/bundle/main.go

@@ -73,7 +73,7 @@ func Do(ctx context.Context) error {
 		return fmt.Errorf("mandatory flag --image is not set")
 	}
 
-	// sanity-check the endpoint, if hostname extraction fails, ignore that failure
+	// check the endpoint, if hostname extraction fails, ignore that failure
 	if hostname, port, err := image.ExtractHostnamePort(flagValues.image); err == nil {
 		if !util.TestConnection(hostname, port, 9) {
 			log.Printf("Warning: a connection test to %s:%d failed. The operation will likely fail.\n", hostname, port)

cmd/git/main.go

@@ -164,7 +164,7 @@ func runGitClone(ctx context.Context) error {
 		return &ExitError{Code: 101, Message: "the 'target' argument must not be empty"}
 	}
 
-	// sanity-check the endpoint, if hostname extraction fails, ignore that failure
+	// check the endpoint, if hostname extraction fails, ignore that failure
 	if hostname, port, err := shpgit.ExtractHostnamePort(flagValues.url); err == nil {
 		if !util.TestConnection(hostname, port, 9) {
 			log.Printf("Warning: a connection test to %s:%d failed. The operation will likely fail.\n", hostname, port)

pkg/git/git.go

@@ -42,7 +42,7 @@ func ExtractHostnamePort(url string) (string, int, error) {
 			port = 22
 
 		default:
-			return "", 0, fmt.Errorf("Unknown protocol: %s", endpoint.Protocol)
+			return "", 0, fmt.Errorf("unknown protocol: %s", endpoint.Protocol)
 		}
 	}
 

pkg/image/endpoint.go

@@ -40,7 +40,7 @@ func ExtractHostnamePort(url string) (string, int, error) {
 			port = 443
 
 		default:
-			return "", 0, fmt.Errorf("Unknown protocol: %s", scheme)
+			return "", 0, fmt.Errorf("unknown protocol: %s", scheme)
 		}
 	}