ForbidNotNormalizedTypeRule: check even multi-catch statements (#231)

Author: janedbal

src/Rule/ForbidNotNormalizedTypeRule.php

@@ -11,6 +11,7 @@
 use PhpParser\Node\IntersectionType;
 use PhpParser\Node\NullableType;
 use PhpParser\Node\Param;
+use PhpParser\Node\Stmt\Catch_;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Function_;
 use PhpParser\Node\Stmt\Property;
@@ -103,9 +104,22 @@ public function processNode(
             );
         }
 
+        if ($node instanceof Catch_) {
+            return $this->checkCatchNativeType($node, $scope);
+        }
+
         return $this->checkInlineVarDoc($node, $scope);
     }
 
+    /**
+     * @return list<RuleError>
+     */
+    private function checkCatchNativeType(Catch_ $node, Scope $scope): array
+    {
+        $multiTypeNode = new UnionType($node->types, $node->getAttributes());
+        return $this->processMultiTypePhpParserNode($multiTypeNode, $scope, 'catch statement');
+    }
+
     /**
      * @return list<RuleError>
      */

tests/Rule/data/ForbidNotNormalizedTypeRule/code.php

@@ -160,4 +160,13 @@ public function testNativeUnions(
     {
     }
 
+    public function testCatch()
+    {
+        try {
+
+        } catch (InterfaceImplementor|MyInterface $k) { // error: Found non-normalized type \ForbidNotNormalizedTypeRule\InterfaceImplementor|\ForbidNotNormalizedTypeRule\MyInterface for catch statement: \ForbidNotNormalizedTypeRule\InterfaceImplementor is a subtype of \ForbidNotNormalizedTypeRule\MyInterface.
+
+        }
+    }
+
 }