feat: add assets to manifest

BREAKING CHANGE: add extra keys to manifest when using copy-webpack-plugin

closes #75

Author: davidmpaz

lib/plugin.js

@@ -47,11 +47,6 @@ ManifestPlugin.prototype.apply = function(compiler) {
 
     var files = compilation.chunks.reduce(function(files, chunk) {
       return chunk.files.reduce(function (files, path) {
-        // Don't add hot updates to manifest
-        if (path.indexOf('hot-update') >= 0) {
-          return files;
-        }
-
         var name = chunk.name ? chunk.name.replace(this.opts.stripSrc, '') : null;
 
         if (name) {
@@ -77,20 +72,37 @@ ManifestPlugin.prototype.apply = function(compiler) {
     // we're getting them this way;
     files = stats.assets.reduce(function (files, asset) {
       var name = moduleAssets[asset.name];
-      if (!name) {
+      if (name) {
+        return files.concat({
+          path: asset.name,
+          name: name,
+          isInitial: false,
+          isChunk: false,
+          isAsset: true,
+          isModuleAsset: true
+        });
+      }
+
+      const isEntryAsset = asset.chunks.length > 0;
+      if (isEntryAsset) {
         return files;
       }
 
       return files.concat({
         path: asset.name,
-        name: name,
+        name: asset.name,
         isInitial: false,
         isChunk: false,
         isAsset: true,
-        isModuleAsset: true
+        isModuleAsset: false
       });
     }, files);
 
+    files = files.filter(function (file) {
+      // Don't add hot updates to manifest
+      return file.path.indexOf('hot-update') === -1;
+    });
+
     // Append optional basepath onto all references.
     // This allows output path to be reflected in the manifest.
     if (this.opts.basePath) {

spec/helpers/copy-plugin-mock.js

@@ -0,0 +1,21 @@
+function FakeCopyWebpackPlugin() {
+};
+
+FakeCopyWebpackPlugin.prototype.apply = function (compiler) {
+  compiler.plugin('emit', function (compilation, callback) {
+
+    var compiledMock = '// some compilation result\n';
+    compilation.assets['third.party.js'] = {
+      size: function () {
+        return compiledMock.length;
+      },
+      source: function () {
+        return compiledMock;
+      }
+    };
+
+    callback();
+  });
+};
+
+module.exports = FakeCopyWebpackPlugin;

spec/plugin.spec.js

@@ -4,6 +4,7 @@ var MemoryFileSystem = require('memory-fs');
 var webpack = require('webpack');
 var _ = require('lodash');
 var ExtractTextPlugin = require('extract-text-webpack-plugin');
+var FakeCopyWebpackPlugin = require('./helpers/copy-plugin-mock');
 var plugin = require('../index.js');
 
 var OUTPUT_DIR = path.join(__dirname, './webpack-out');
@@ -476,7 +477,7 @@ describe('ManifestPlugin', function() {
           var manifest = JSON.parse(fs.readFileSync(manifestPath).toString());
 
           expect(manifest).toEqual({
-           'main.js': 'main.js'
+            'main.js': 'main.js'
           });
 
           done();
@@ -499,7 +500,7 @@ describe('ManifestPlugin', function() {
           var manifest = JSON.parse(fs.readFileSync(manifestPath).toString());
 
           expect(manifest).toEqual({
-           'main.js': 'main.js'
+            'main.js': 'main.js'
           });
 
           done();
@@ -668,4 +669,75 @@ describe('ManifestPlugin', function() {
       });
     });
   });
+
+  describe('with CopyWebpackPlugin', function () {
+    it('works when including copied assets', function (done) {
+      webpackCompile({
+        context: __dirname,
+        entry: {
+          one: './fixtures/file.js'
+        },
+        plugins: [
+          new FakeCopyWebpackPlugin(),
+          new plugin()
+        ]
+      }, {}, function (manifest, stats) {
+        expect(manifest).toEqual({
+          'one.js': 'one.js',
+          'third.party.js': 'third.party.js'
+        });
+
+        done();
+      });
+    });
+
+    it('doesn\'t add duplicates when prefixes definitions with a base path', function (done) {
+      webpackCompile({
+        context: __dirname,
+        entry: {
+          one: './fixtures/file.js',
+        },
+        output: {
+          filename: '[name].[hash].js'
+        },
+        plugins: [
+          new FakeCopyWebpackPlugin(),
+          new plugin({
+            basePath: '/app/',
+            publicPath: '/app/'
+          })
+        ]
+      }, {}, function (manifest, stats) {
+        expect(manifest).toEqual({
+          '/app/one.js': '/app/one.' + stats.hash + '.js',
+          '/app/third.party.js': '/app/third.party.js'
+        });
+
+        done();
+      });
+    });
+
+    it('doesn\'t add duplicates when used with hashes in the filename', function (done) {
+      webpackCompile({
+        context: __dirname,
+        entry: {
+          one: './fixtures/file.js',
+        },
+        output: {
+          filename: '[name].[hash].js'
+        },
+        plugins: [
+          new FakeCopyWebpackPlugin(),
+          new plugin()
+        ]
+      }, {}, function(manifest, stats) {
+        expect(manifest).toEqual({
+          'one.js': 'one.' + stats.hash + '.js',
+          'third.party.js': 'third.party.js'
+        });
+
+        done();
+      });
+    });
+  });
 });