Make highlight tests fail when new syntaxes don't have fixtures

Author: dan-hipschman

CHANGELOG.md

@@ -7,6 +7,7 @@
 - Fix `BAT_THEME_DARK` and `BAT_THEME_LIGHT` being ignored, see issue #3171 and PR #3168 (@bash)
 - Prevent `--list-themes` from outputting default theme info to stdout when it is piped, see #3189 (@einfachIrgendwer0815)
 - Rename some submodules to fix Dependabot submodule updates, see issue #3198 and PR #3201 (@victor-gp)
+- Make highlight tests fail when new syntaxes don't have fixtures PR #3255 (@dan-hipschman)
 
 ## Other
 

tests/syntax-tests/compare_highlighted_versions.py

@@ -12,13 +12,15 @@ def compare_highlighted_versions(root_old, root_new):
     print(" -", root_old)
     print(" -", root_new)
     has_changes = False
-    for path_old in glob.glob(path.join(root_old, "*", "*")):
-        filename = path.basename(path_old)
-        dirname = path.basename(path.dirname(path_old))
+    # Used to check for newly added files that don't have a test
+    unknown_files = {strip_root(p) for p in glob.glob(path.join(root_new, "*", "*"))}
 
-        path_new = path.join(root_new, dirname, filename)
+    for path_old in glob.glob(path.join(root_old, "*", "*")):
+        rel_path = strip_root(path_old)
+        unknown_files.discard(rel_path)
+        path_new = path.join(root_new, rel_path)
 
-        print("\n========== {}/{}".format(dirname, filename))
+        print("\n========== {}".format(rel_path))
 
         with open(path_old) as file_old:
             lines_old = file_old.readlines()
@@ -39,11 +41,21 @@ def compare_highlighted_versions(root_old, root_new):
             has_changes = True
         else:
             print("No changes")
-    print()
 
+    for f in unknown_files:
+        print("\n========== {}: No fixture for this language, run update.sh".format(f))
+        has_changes = True
+
+    print()
     return has_changes
 
 
+def strip_root(p: str) -> str:
+    filename = path.basename(p)
+    dirname = path.basename(path.dirname(p))
+    return path.join(dirname, filename)
+
+
 if __name__ == "__main__":
     parser = argparse.ArgumentParser(
         description="This script compares two directories that were created "