Skip to content

Commit 34357dd

Browse files
committed
fix(integer-base-converter): fix conversion for number of more than 32bits
1 parent e336ebe commit 34357dd

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

src/tools/integer-base-converter/integer-base-converter.model.test.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ describe('integer-base-converter', () => {
2626
expect(convertBase({ value: '0b10101010', fromBase: -1, toBase: 10 })).toEqual('170');
2727
expect(convertBase({ value: '0b_1010_1010', fromBase: -1, toBase: 10 })).toEqual('170');
2828
expect(convertBase({ value: '192,654', fromBase: 10, toBase: 8 })).toEqual('570216');
29+
expect(convertBase({ value: '42540766411283223938465490632011909384', fromBase: 10, toBase: 10 })).toEqual('42540766411283223938465490632011909384');
30+
expect(convertBase({ value: '42540766411283223938465490632011909384', fromBase: 10, toBase: 16 })).toEqual('20010db8000085a300000000ac1f8908');
31+
expect(convertBase({ value: '20010db8000085a300000000ac1f8908', fromBase: 16, toBase: 10 })).toEqual('42540766411283223938465490632011909384');
2932
});
3033
});
3134
});

src/tools/integer-base-converter/integer-base-converter.model.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,16 @@ export function convertBase(
4646
let decValue = cleanedValue
4747
.split('')
4848
.reverse()
49-
.reduce((carry: number, digit: string, index: number) => {
49+
.reduce((carry: bigint, digit: string, index: number) => {
5050
if (!fromRange.includes(digit)) {
5151
throw new Error(`Invalid digit "${digit}" for base ${finalFromBase}.`);
5252
}
53-
return (carry += fromRange.indexOf(digit) * finalFromBase ** index);
54-
}, 0);
53+
return (carry += BigInt(fromRange.indexOf(digit)) * BigInt(finalFromBase) ** BigInt(index));
54+
}, 0n);
5555
let newValue = '';
5656
while (decValue > 0) {
57-
newValue = toRange[decValue % toBase] + newValue;
58-
decValue = (decValue - (decValue % toBase)) / toBase;
57+
newValue = toRange[Number(decValue % BigInt(toBase))] + newValue;
58+
decValue = (decValue - (decValue % BigInt(toBase))) / BigInt(toBase);
5959
}
6060
return newValue || '0';
6161
}

0 commit comments

Comments
 (0)