Skip to content

fix(WebOS): Do not throw error during parsing ID3 #8623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025

Conversation

tykus160
Copy link
Member

@tykus160 tykus160 commented May 21, 2025

TypedArray.prototype.indexOf is available since Chrome 45, which means it's not implemented on WebOS 3 (using Chromium 38). As we extensively use this method in Id3Utils it leads to fatal errors on this platform whenever we encounter ID3 tags.
For completeness and to prevent errors in the future, I also added implementations of connected methods: lastIndexOf & includes.

@tykus160 tykus160 added this to the v4.15 milestone May 21, 2025
@tykus160 tykus160 requested review from avelad and TAhub May 21, 2025 07:09
@tykus160 tykus160 added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release platform: WebOS Issues affecting WebOS labels May 21, 2025
@avelad avelad merged commit b2595ce into shaka-project:main May 21, 2025
14 of 17 checks passed
avelad pushed a commit that referenced this pull request May 22, 2025
`TypedArray.prototype.indexOf` is available since Chrome 45, which means
it's not implemented on WebOS 3 (using Chromium 38). As we extensively
use this method in `Id3Utils` it leads to fatal errors on this platform
whenever we encounter ID3 tags.
For completeness and to prevent errors in the future, I also added
implementations of connected methods: `lastIndexOf` & `includes`.
avelad pushed a commit that referenced this pull request May 22, 2025
`TypedArray.prototype.indexOf` is available since Chrome 45, which means
it's not implemented on WebOS 3 (using Chromium 38). As we extensively
use this method in `Id3Utils` it leads to fatal errors on this platform
whenever we encounter ID3 tags.
For completeness and to prevent errors in the future, I also added
implementations of connected methods: `lastIndexOf` & `includes`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: WebOS Issues affecting WebOS priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants