Skip to content

feat: Add additional codec & channel count configs to Adaptation Set Criteria #8597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dpfister2
Copy link
Contributor

@dpfister2 dpfister2 commented May 12, 2025

Close #8587

@avelad
Copy link
Member

avelad commented May 12, 2025

@dpfister2 Please, see #8587 (comment)

@avelad avelad self-requested a review May 12, 2025 15:31
@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent labels May 12, 2025
@avelad avelad added this to the v4.15 milestone May 12, 2025
@avelad avelad changed the title feat: Add New Adaptation Set Criteria Config Params feat: Add additional codec & channel count configs to Adaptation Set Criteria May 12, 2025
@shaka-bot
Copy link
Collaborator

shaka-bot commented May 12, 2025

Incremental code coverage: 93.44%

@dpfister2
Copy link
Contributor Author

Added both new channel count and audio codec configs to preference based criteria. In both cases we fallback to active codec/channel count if we find no matches for the pre-existing config values. Audio codec also falls back one level further with preferredAudioCodecs

@dpfister2 dpfister2 requested a review from avelad May 19, 2025 19:50
@avelad
Copy link
Member

avelad commented May 19, 2025

Added both new channel count and audio codec configs to preference based criteria. In both cases we fallback to active codec/channel count if we find no matches for the pre-existing config values. Audio codec also falls back one level further with preferredAudioCodecs

Please add some unit tests

@dpfister2
Copy link
Contributor Author

dpfister2 commented May 20, 2025

Please add some unit tests

Added, and added preferred channel count to pref based criteria. But I had some thought on my implementation for that. The codec fallback makes sense, but applying it to channel count doesn't seem right. If a channel count isn't provided, does it make sense to fall back to active channel count? In the case where the expectation is to not filter anything (by passing 0) this would instead filter by what variant is currently selected.

Does that make sense @avelad? Any thoughts?

@avelad avelad requested review from TAhub and tykus160 May 21, 2025 07:30
@tykus160 tykus160 merged commit ce830d7 into shaka-project:main May 21, 2025
31 of 33 checks passed
@tykus160 tykus160 deleted the dp-add-adaption-set-criteria-configs branch May 21, 2025 08:13
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 20, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional codec & channel count configs to Adaptation Set Criteria
5 participants