-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: Add additional codec & channel count configs to Adaptation Set Criteria #8597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add additional codec & channel count configs to Adaptation Set Criteria #8597
Conversation
@dpfister2 Please, see #8587 (comment) |
Incremental code coverage: 93.44% |
Added both new channel count and audio codec configs to preference based criteria. In both cases we fallback to active codec/channel count if we find no matches for the pre-existing config values. Audio codec also falls back one level further with |
Please add some unit tests |
Added, and added preferred channel count to pref based criteria. But I had some thought on my implementation for that. The codec fallback makes sense, but applying it to channel count doesn't seem right. If a channel count isn't provided, does it make sense to fall back to active channel count? In the case where the expectation is to not filter anything (by passing 0) this would instead filter by what variant is currently selected. Does that make sense @avelad? Any thoughts? |
Close #8587