fix: Support more Dolby codec notations #8387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Player errors out for Dolby contents in adaptive streaming because correct mimetype is not identified. This change adds ac3, ac-3, eac3, ec-3, and ac-4 mimetype support.
avelad
added
type: bug
avelad
approved these changes
Apr 2, 2025
avelad
requested changes
Apr 2, 2025
Player errors out for Dolby contents in adaptive streaming because correct mimetype is not identified. This change adds ac3, ac-3, eac3, ec-3, and ac-4 mimetype support.
avelad
approved these changes
Apr 2, 2025
|
Incremental code coverage: 100.00% |
|
As the commit message and PR title are rather vague it won't make much sense in the changelog, as shaka-player already has support for Dolby content. Could you please choose a more suitable message e.g. |
avelad
pushed a commit
that referenced
this pull request
Apr 4, 2025
Player errors out for Dolby contents in adaptive streaming because correct mimetype is not identified. This change adds ac3, ac-3, eac3, ec-3, and ac-4 mimetype support. --------- Co-authored-by: Srikanth Peddibhotla <[email protected]>
avelad
pushed a commit
that referenced
this pull request
Apr 4, 2025
Player errors out for Dolby contents in adaptive streaming because correct mimetype is not identified. This change adds ac3, ac-3, eac3, ec-3, and ac-4 mimetype support. --------- Co-authored-by: Srikanth Peddibhotla <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Player errors out for Dolby contents in adaptive streaming because correct mimetype is not identified.
This change adds ac3, ac-3, eac3, ec-3, and ac-4 mimetype support.