Skip to content

fix(Ads): Fix overlay interstitial when the seeked is outside of the current window #8288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Mar 17, 2025

No description provided.

@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P1 Big impact or workaround impractical; resolve before feature release labels Mar 17, 2025
@avelad avelad added this to the v4.15 milestone Mar 17, 2025
@avelad avelad merged commit 9fd5900 into shaka-project:main Mar 17, 2025
23 checks passed
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 0.00%

@avelad avelad deleted the overlay-seeked branch March 17, 2025 16:44
avelad added a commit that referenced this pull request Mar 19, 2025
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label May 16, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants