perf: Do not process stream DRM info several times (#8505)

Author: tykus160

lib/media/manifest_filterer.js

@@ -91,9 +91,17 @@ shaka.media.ManifestFilterer = class {
           this.drmEngine_ ? this.drmEngine_.getDrmInfo() : null;
       // DrmEngine.newInitData() requires mediaKeys to be available.
       if (currentDrmInfo && this.drmEngine_.getMediaKeys()) {
+        const streams = new Set();
         for (const variant of manifest.variants) {
-          this.processDrmInfos(currentDrmInfo.keySystem, variant.video);
-          this.processDrmInfos(currentDrmInfo.keySystem, variant.audio);
+          if (variant.audio) {
+            streams.add(variant.audio);
+          }
+          if (variant.video) {
+            streams.add(variant.video);
+          }
+        }
+        for (const stream of streams) {
+          this.processDrmInfos(currentDrmInfo.keySystem, stream);
         }
       }
       this.checkRestrictedVariants(manifest);
@@ -122,13 +130,9 @@ shaka.media.ManifestFilterer = class {
 
   /**
    * @param {string} keySystem
-   * @param {?shaka.extern.Stream} stream
+   * @param {!shaka.extern.Stream} stream
    */
   processDrmInfos(keySystem, stream) {
-    if (!stream) {
-      return;
-    }
-
     for (const drmInfo of stream.drmInfos) {
       // Ignore any data for different key systems.
       if (drmInfo.keySystem == keySystem) {
@@ -162,27 +166,15 @@ shaka.media.ManifestFilterer = class {
     /** @type {!Set<string>} */
     const badKeyStatuses = new Set();
 
+    const streams = new Set();
+
     for (const variant of manifest.variants) {
       // TODO: Combine with onKeyStatus_.
-      const streams = [];
       if (variant.audio) {
-        streams.push(variant.audio);
+        streams.add(variant.audio);
       }
       if (variant.video) {
-        streams.push(variant.video);
-      }
-
-      for (const stream of streams) {
-        if (stream.keyIds.size) {
-          for (const keyId of stream.keyIds) {
-            const keyStatus = keyStatusMap[isGlobalStatus ? '00' : keyId];
-            if (!keyStatus) {
-              missingKeys.add(keyId);
-            } else if (restrictedStatuses.includes(keyStatus)) {
-              badKeyStatuses.add(keyStatus);
-            }
-          }
-        }  // if (stream.keyIds.size)
+        streams.add(variant.video);
       }
 
       if (!variant.allowedByApplication) {
@@ -192,6 +184,19 @@ shaka.media.ManifestFilterer = class {
       }
     }
 
+    for (const stream of streams) {
+      if (stream.keyIds.size) {
+        for (const keyId of stream.keyIds) {
+          const keyStatus = keyStatusMap[isGlobalStatus ? '00' : keyId];
+          if (!keyStatus) {
+            missingKeys.add(keyId);
+          } else if (restrictedStatuses.includes(keyStatus)) {
+            badKeyStatuses.add(keyStatus);
+          }
+        }
+      }  // if (stream.keyIds.size)
+    }
+
     if (!hasPlayable) {
       /** @type {shaka.extern.RestrictionInfo} */
       const data = {