Skip to content

Commit 0d7838e

Browse files
authored
fix(UI): honors singleClickForPlayAndPause when made a single tap with seekOnTaps = true (#8393)
1 parent 05f3318 commit 0d7838e

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

ui/controls.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -980,7 +980,7 @@ shaka.ui.Controls = class extends shaka.util.FakeEventTarget {
980980
});
981981

982982
this.eventManager_.listen(this.controlsContainer_, 'click', () => {
983-
this.onContainerClick_();
983+
this.onContainerClick();
984984
});
985985

986986
this.eventManager_.listen(this.controlsContainer_, 'dblclick', () => {
@@ -1203,7 +1203,7 @@ shaka.ui.Controls = class extends shaka.util.FakeEventTarget {
12031203
this.clientAdContainer_.classList.add('shaka-client-side-ad-container');
12041204
shaka.ui.Utils.setDisplay(this.clientAdContainer_, false);
12051205
this.eventManager_.listen(this.clientAdContainer_, 'click', () => {
1206-
this.onContainerClick_();
1206+
this.onContainerClick();
12071207
});
12081208
this.videoContainer_.appendChild(this.clientAdContainer_);
12091209
}
@@ -1677,8 +1677,10 @@ shaka.ui.Controls = class extends shaka.util.FakeEventTarget {
16771677
}
16781678
}
16791679

1680-
/** @private */
1681-
onContainerClick_() {
1680+
/**
1681+
* Manage the container click.
1682+
*/
1683+
onContainerClick() {
16821684
if (!this.enabled_ || this.isPlayingVR()) {
16831685
return;
16841686
}

ui/hidden_seek_button.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ shaka.ui.HiddenSeekButton = class extends shaka.ui.Element {
5555
this.hideSeekButtonContainerTimer_ = new shaka.util.Timer(() => {
5656
const seekSeconds = parseInt(this.seekValue_.textContent, 10);
5757
if (seekSeconds === 0) {
58-
this.controls.playPausePresentation();
58+
this.controls.onContainerClick();
5959
}
6060
this.hideSeekButtonContainer_();
6161
});

0 commit comments

Comments
 (0)