Skip to content

Commit 023d06a

Browse files
authored
fix: Add new parameters to thumbnails in order to work with cast proxy (#8554)
1 parent 1cf5cad commit 023d06a

File tree

3 files changed

+15
-7
lines changed

3 files changed

+15
-7
lines changed

externs/shaka/player.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2892,6 +2892,8 @@ shaka.extern.LanguageRole;
28922892
* startTime: number,
28932893
* duration: number,
28942894
* uris: !Array<string>,
2895+
* startByte: number,
2896+
* endByte: ?number,
28952897
* width: number,
28962898
* sprite: boolean,
28972899
* mimeType: ?string,
@@ -2919,6 +2921,12 @@ shaka.extern.LanguageRole;
29192921
* @property {!Array<string>} uris
29202922
* An array of URIs to attempt. They will be tried in the order they are
29212923
* given.
2924+
* @property {number} startByte
2925+
* The offset from the start of the uri resource.
2926+
* @property {?number} endByte
2927+
* The offset from the start of the resource to the end of the segment,
2928+
* inclusive. A value of null indicates that the segment extends to the end
2929+
* of the resource.
29222930
* @property {number} width
29232931
* The thumbnail width in px.
29242932
* @property {boolean} sprite

lib/player.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5448,6 +5448,8 @@ shaka.Player = class extends shaka.util.FakeEventTarget {
54485448
startTime: thumbnailTime,
54495449
duration: thumbnailDuration,
54505450
uris: reference.getUris(),
5451+
startByte: reference.getStartByte(),
5452+
endByte: reference.getEndByte(),
54515453
width: width,
54525454
sprite: sprite,
54535455
mimeType: reference.mimeType || imageStream.mimeType,

ui/seek_bar.js

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -586,10 +586,8 @@ shaka.ui.SeekBar = class extends shaka.ui.RangeElement {
586586
let uri = thumbnail.uris[0].split('#xywh=')[0];
587587
if (!this.lastThumbnail_ ||
588588
uri !== this.lastThumbnail_.uris[0].split('#xywh=')[0] ||
589-
thumbnail.segment.getStartByte() !=
590-
this.lastThumbnail_.segment.getStartByte() ||
591-
thumbnail.segment.getEndByte() !=
592-
this.lastThumbnail_.segment.getEndByte()) {
589+
thumbnail.startByte != this.lastThumbnail_.startByte ||
590+
thumbnail.endByte != this.lastThumbnail_.endByte) {
593591
this.lastThumbnail_ = thumbnail;
594592
if (this.lastThumbnailPendingRequest_) {
595593
this.lastThumbnailPendingRequest_.abort();
@@ -602,9 +600,9 @@ shaka.ui.SeekBar = class extends shaka.ui.RangeElement {
602600
const type =
603601
shaka.net.NetworkingEngine.AdvancedRequestType.MEDIA_SEGMENT;
604602
const request = shaka.util.Networking.createSegmentRequest(
605-
thumbnail.segment.getUris(),
606-
thumbnail.segment.getStartByte(),
607-
thumbnail.segment.getEndByte(),
603+
thumbnail.uris,
604+
thumbnail.startByte,
605+
thumbnail.endByte,
608606
this.player.getConfiguration().streaming.retryParameters);
609607
this.lastThumbnailPendingRequest_ = this.player.getNetworkingEngine()
610608
.request(requestType, request, {type});

0 commit comments

Comments
 (0)