fix(ios): message sent to deallocated instance (TheWidlarzGroup#1482)

n1ru4l · AnteWall · commit bc405f8e4e52 · 2019-03-01T15:09:43.000+01:00
* fix(ios): message sent to deallocated instance

* chore: update changelog
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ### next
 
 * Fix loading package resolved videos when using video-caching [#1438](https://github.com/react-native-community/react-native-video/pull/1438)
+* Fix "message sent to deallocated instance" crash on ios [#1482](https://github.com/react-native-community/react-native-video/pull/1482)
 
 ### Version 4.3.0
 * Fix iOS video not displaying after switching source [#1395](https://github.com/react-native-community/react-native-video/pull/1395)
diff --git a/ios/Video/RCTVideo.m b/ios/Video/RCTVideo.m
@@ -202,6 +202,7 @@ - (void)dealloc
   [self removePlayerLayer];
   [self removePlayerItemObservers];
   [_player removeObserver:self forKeyPath:playbackRate context:nil];
+  [_player removeObserver:self forKeyPath:externalPlaybackActive context: nil];
 }
 
 #pragma mark - App lifecycle handlers

Original file line number	Diff line number	Diff line change
`@@ -202,6 +202,7 @@ - (void)dealloc`
`202`	`202`	`[self removePlayerLayer];`
`203`	`203`	`[self removePlayerItemObservers];`
`204`	`204`	`[_player removeObserver:self forKeyPath:playbackRate context:nil];`
	`205`	`+ [_player removeObserver:self forKeyPath:externalPlaybackActive context: nil];`
`205`	`206`	`}`
`206`	`207`
`207`	`208`	`#pragma mark - App lifecycle handlers`