Skip to content

Sync version numbers of 5ever crates? #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicoburns opened this issue Apr 15, 2025 · 4 comments
Open

Sync version numbers of 5ever crates? #605

nicoburns opened this issue Apr 15, 2025 · 4 comments

Comments

@nicoburns
Copy link
Contributor

How would people feel about updating the version numbers of html5ever, xml5ever and markup5ever to be the same, and then keeping them in sync going forwards?

I think this would be easier both for 5ever maintainers and for consumers of the 5ever crates.

@simonwuelker
Copy link
Contributor

That feels weird, because xml5ever and html5ever can be used independently of each other.

@jdm
Copy link
Member

jdm commented Apr 17, 2025

Yeah, I've been thinking about this on and off, and it doesn't feel like a meaningful reduction in work as a consumer of the crate, and it potentially leads to an unnecessary increase in breaking version releases.

@nicoburns
Copy link
Contributor Author

My take is that upgrading to a new "breaking" version that doesn't actually contain any changes is trivial (/not a big deal), whereas figuring out which markup version matches the version of xml/html you're using is annoying (and matching html to xml too if you're using both). And internally we keep getting the release PRs wrong because we're not updating the versions in all the correct places.

But eh. I don't care strongly about this. Maybe an alternative would be to create a table of compatible versions in the README. And perhaps get rid of the Cargo.toml lines in the crate-specific READMEs (as those are what keep getting out of sync).

@simonwuelker
Copy link
Contributor

whereas figuring out which markup version matches the version of xml/html you're using is annoying

Perhaps html5ever/xml5ever should re-export all necessary pieces of markup5ever, such that you never use markup5ever directly, thus removing the need to find a compatible version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants