New waitForDeployment check logic (#215)

* exponential and (very) longer waitForDeployment interval

* Bump version

* setExponentialInterval fix (timer cancelation not working for synchronous callback)

* variable name refactoring in setExponentialInterval

Author: faxioman

lib/deploy.js

@@ -211,12 +211,12 @@ function waitForDeployment(funcName, requestMoment, namespace, options) {
   let successfulCount = 0;
   let previousPodStatus = '';
   return new BbPromise((resolve, reject) => {
-    const loop = setInterval(() => {
-      if (retries > 10) {
+    const loop = helpers.setExponentialInterval(() => {
+      if (retries > 30) {
         opts.log(
           `Giving up, unable to retrieve the status of the ${funcName} deployment. `
         );
-        clearInterval(loop);
+        loop.clearInterval();
         reject(`Unable to retrieve the status of the ${funcName} deployment`);
       }
       let runningPods = 0;
@@ -249,7 +249,7 @@ function waitForDeployment(funcName, requestMoment, namespace, options) {
                 } else if (pod.status.containerStatuses[0].restartCount > 2) {
                   opts.log('ERROR: Failed to deploy the function');
                   process.exitCode = process.exitCode || 1;
-                  clearInterval(loop);
+                  loop.clearInterval();
                 }
               }
             });
@@ -281,7 +281,7 @@ function waitForDeployment(funcName, requestMoment, namespace, options) {
                       opts.log(`Unable to find internal service for ${funcName}. Retrying...`);
                     } else {
                       opts.log(`Function ${funcName} successfully deployed`);
-                      clearInterval(loop);
+                      loop.clearInterval();
                       resolve();
                     }
                   }
@@ -304,7 +304,7 @@ function waitForDeployment(funcName, requestMoment, namespace, options) {
           }
         }
       });
-    }, 2000);
+    }, 2000, 30000);
   });
 }
 

lib/helpers.js

@@ -241,6 +241,32 @@ function getDeployableItemsNumber(functions) {
   return _.sum([_.keys(functions).length].concat(_.map(functions, f => _.size(f.events))));
 }
 
+function setExponentialInterval(targetFunction, initialDelay, maxDelay) {
+  let delay = initialDelay;
+  let timer;
+  const timerWrapper = () => {
+    try {
+      targetFunction();
+    } catch (ex) {
+      console.error(ex);
+    }
+    if (timer) {
+      delay = Math.round(delay * 1.2);
+      if (delay > maxDelay) {
+        delay = maxDelay;
+      }
+      timer = setTimeout(timerWrapper, delay);
+    }
+  };
+  timer = setTimeout(timerWrapper, delay);
+  return {
+    clearInterval: () => {
+      clearTimeout(timer);
+      timer = null;
+    },
+  };
+}
+
 module.exports = {
   warnUnsupportedOptions,
   loadKubeConfig,
@@ -250,4 +276,5 @@ module.exports = {
   getRuntimeDepfile,
   checkFinished,
   getDeployableItemsNumber,
+  setExponentialInterval,
 };

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "serverless-kubeless",
-  "version": "0.10.1",
+  "version": "0.10.2",
   "description": "This plugin enables support for Kubeless within the [Serverless Framework](https://github.com/serverless).",
   "main": "index.js",
   "directories": {