Skip to content

[BUG] Cup fails if a docker registry is unavailable #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rootforbid opened this issue May 10, 2025 · 5 comments
Closed

[BUG] Cup fails if a docker registry is unavailable #104

rootforbid opened this issue May 10, 2025 · 5 comments
Labels
bug Something isn't working

Comments

@rootforbid
Copy link

rootforbid commented May 10, 2025 •
edited
Loading

Describe the bug
I have a bunch of docker images. Some from Dockerhub, Github and Codeberg.
I have precisely only 1 docker image hosted on Codeberg, which happens to be down right now.
Because of this, Cup simply doesn't output any results for the other images that aren't on Codeberg.

To Reproduce
Since the registry in question is down, you probably won't be able to reproduce unless you already have an existing image from a registry that is currently down.
Steps to reproduce the behavior:

  1. Get an image from Codeberg: docker pull codeberg.org/forgejo/forgejo
  2. cup check
  3. The check fails with the following error:
ERROR GET https://codeberg.org/v2/: Unexpected error: 
<!doctype html>
<title>502 Service unavailable - Codeberg.org</title>
<meta name="viewport" content="width=device-width, initial-scale=1">
<style>
        body { text-align: center; font: 20px Helvetica, sans-serif; color: #333; }
h1 { font-size: 3rem; }
article { display: block; text-align: start; margin: 0 auto; }
a { color: #2185d0; text-decoration: none; }
a:hover { text-decoration: none; }
@media (prefers-color-scheme: dark) {
        body { background-color: #171e26; color: #fff; }
        a { color: #4793cc; }
}
@media only screen and (min-width: 48rem) {
        body { padding: 9rem; }
        article { width: 40rem; }
}

</style>

<article>
        <h1>Service unavailable</h1>
        <p>This Codeberg service is currently unavailable due to technical difficulties, maintenance or a service update.</p>
        <p>We are sorry for the inconvenience, and we do hope that we'll be back soon.</p>

                <p>There is currently a status note:
                        <blockquote>
                                <p>We are aware of the outage and investigating.</p>

                        </blockquote>
                </p>

        <p>
                If this error continues to show up, please have a look at our <a href="https://status.codeberg.org">status page</a>.<br>
                For more information on possible outages, follow us on <a href="https://social.anoxinon.de/@codeberg">Mastodon</a> or have a look at our <a href="https://matrix.to/#/#codeberg.org:matrix.org">Matrix channel</a>.
        </p>
</article>

Expected behavior
The check should just continue with the other images hosted on unaffected registries regardless, instead of halting everything. Basically the check ends just because of a single registry being down.

System info (please complete the following information):

  • OS: Debian 12 x86_64
  • Docker daemon version:
Client: Docker Engine - Community
 Version:           28.1.1
 API version:       1.49
 Go version:        go1.23.8
 Git commit:        4eba377
 Built:             Fri Apr 18 09:52:57 2025
 OS/Arch:           linux/amd64
 Context:           default

Server: Docker Engine - Community
 Engine:
  Version:          28.1.1
  API version:      1.49 (minimum version 1.24)
  Go version:       go1.23.8
  Git commit:       01f442b
  Built:            Fri Apr 18 09:52:57 2025
  OS/Arch:          linux/amd64
  Experimental:     true
 containerd:
  Version:          1.7.27
  GitCommit:        05044ec0a9a75232cad458027ca83437aae3f4da
 runc:
  Version:          1.2.5
  GitCommit:        v1.2.5-0-g59923ef
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0
  • Cup version: 3.3.0
@rootforbid rootforbid added the bug Something isn't working label May 10, 2025
@sergi0g
Copy link
Owner

sergi0g commented May 10, 2025

Hey @rootforbid! Thanks for reporting this! I'll fix this ASAP.

@sergi0g
Copy link
Owner

sergi0g commented May 10, 2025

I just pushed a fix. It should work (not sure since it's from my phone). I'll release a nightly. Can you test?

@sergi0g
Copy link
Owner

sergi0g commented May 10, 2025

Didn't work, give me a few minutes to fix this.

@sergi0g
Copy link
Owner

sergi0g commented May 10, 2025

I pushed a nightly, should be ready in a few minutes.

@rootforbid
Copy link
Author

Thanks for taking care of this so quick!
By the time I'm posting this, Codeberg already came back online, so I can't really test this accurately.
I'm sure your fix took care of it regardless :)

@Collabeta Collabeta mentioned this issue May 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rootforbid @sergi0g