Skip to content

com_objects.h Float handling #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnampf1 opened this issue Oct 1, 2024 · 0 comments
Open

com_objects.h Float handling #108

gnampf1 opened this issue Oct 1, 2024 · 0 comments

Comments

@gnampf1
Copy link
Contributor

gnampf1 commented Oct 1, 2024

Float handling in com_objects.h must be revised.

  • objectWriteFloat takes an int as parameter, wie scaling value*100
  • objectReadFloat returns an float, but always contains value*100, so no real floating point value, but just an int
  • naming of both methods is confusing, as the only apply to DPT9-groupobjects, not to real float DPTs
    Method should better be renamed to something like objectWriteDPT9, and use the real floating value as input/output, not scaled by 100 as int
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant