Skip to content

Commit cdcd2f6

Browse files
Hanccnixon
Han
authored and
ccnixon
committed
Release 1.2.0
* use https
1 parent b0a497c commit cdcd2f6

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

integrations/analytics.js-integration-doubleclick-floodlight/HISTORY.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11

2+
1.2.0 / 2017-04-04
3+
==================
4+
5+
* Enforce using https
6+
27
1.1.0 / 2016-11-09
38
==================
49

integrations/analytics.js-integration-doubleclick-floodlight/lib/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ var qs = require('component-querystring');
1515

1616
var Floodlight = module.exports = integration('DoubleClick Floodlight')
1717
.option('source', '')
18-
.tag('<iframe src="http://ad.doubleclick.net/activity;src={{ src }};type={{ type }};cat={{ cat }};ord={{ ord }}{{ customVariables }}?">')
18+
.tag('<iframe src="https://ad.doubleclick.net/activity;src={{ src }};type={{ type }};cat={{ cat }};ord={{ ord }}{{ customVariables }}?">')
1919
.mapping('events');
2020

2121
/**

integrations/analytics.js-integration-doubleclick-floodlight/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@segment/analytics.js-integration-doubleclick-floodlight",
33
"description": "The DoubleClick Floodlight analytics.js integration.",
4-
"version": "1.1.0",
4+
"version": "1.2.0",
55
"keywords": [
66
"analytics.js",
77
"analytics.js-integration",

integrations/analytics.js-integration-doubleclick-floodlight/test/index.test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ describe('DoubleClick Floodlight', function() {
8787
});
8888

8989
it('should fire a basic floodlight tag properly', function() {
90-
var iframe = '<iframe src="http://ad.doubleclick.net/activity'
90+
var iframe = '<iframe src="https://ad.doubleclick.net/activity'
9191
+ ';src=' + options.source
9292
+ ';type=' + options.events[1].value.type
9393
+ ';cat=' + options.events[1].value.cat
@@ -99,7 +99,7 @@ describe('DoubleClick Floodlight', function() {
9999
});
100100

101101
it('should fire a floodlight tag with custom variables properly', function() {
102-
var iframe = '<iframe src="http://ad.doubleclick.net/activity'
102+
var iframe = '<iframe src="https://ad.doubleclick.net/activity'
103103
+ ';src=' + options.source
104104
+ ';type=' + options.events[0].value.type
105105
+ ';cat=' + options.events[0].value.cat

0 commit comments

Comments
 (0)