Skip to content

Commit 2fb0190

Browse files
committed
[IGNORE]: extracted in hotwired#1028
1 parent a653d12 commit 2fb0190

File tree

4 files changed

+12
-5
lines changed

4 files changed

+12
-5
lines changed

src/core/drive/morph_renderer.js

+3
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@ import { dispatch, nextAnimationFrame } from "../../util"
33
import { Renderer } from "../renderer"
44

55
export class MorphRenderer extends Renderer {
6+
static renderElement(currentElement, newElement) {
7+
}
8+
69
async render() {
710
if (this.willRender) await this.#morphBody()
811
}

src/core/drive/page_view.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export class PageView extends View {
1919
const shouldMorphPage = this.isPageRefresh(visit) && this.snapshot.shouldMorphPage
2020
const rendererClass = shouldMorphPage ? MorphRenderer : PageRenderer
2121

22-
const renderer = new rendererClass(this.snapshot, snapshot, PageRenderer.renderElement, isPreview, willRender)
22+
const renderer = new rendererClass(this.snapshot, snapshot, isPreview, willRender)
2323

2424
if (!renderer.shouldRender) {
2525
this.forceReloaded = true
@@ -32,7 +32,7 @@ export class PageView extends View {
3232

3333
renderError(snapshot, visit) {
3434
visit?.changeHistory()
35-
const renderer = new ErrorRenderer(this.snapshot, snapshot, ErrorRenderer.renderElement, false)
35+
const renderer = new ErrorRenderer(this.snapshot, snapshot, false)
3636
return this.render(renderer)
3737
}
3838

src/core/frames/frame_controller.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ export class FrameController {
307307

308308
if (newFrameElement) {
309309
const snapshot = new Snapshot(newFrameElement)
310-
const renderer = new FrameRenderer(this, this.view.snapshot, snapshot, FrameRenderer.renderElement, false, false)
310+
const renderer = new FrameRenderer(this, this.view.snapshot, snapshot, false, false)
311311
if (this.view.renderPromise) await this.view.renderPromise
312312
this.changeHistory()
313313

src/core/renderer.js

+6-2
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,16 @@ import { Bardo } from "./bardo"
33
export class Renderer {
44
#activeElement = null
55

6-
constructor(currentSnapshot, newSnapshot, renderElement, isPreview, willRender = true) {
6+
static renderElement(currentElement, newElement) {
7+
// Abstract method
8+
}
9+
10+
constructor(currentSnapshot, newSnapshot, isPreview, willRender = true) {
711
this.currentSnapshot = currentSnapshot
812
this.newSnapshot = newSnapshot
913
this.isPreview = isPreview
1014
this.willRender = willRender
11-
this.renderElement = renderElement
15+
this.renderElement = this.constructor.renderElement
1216
this.promise = new Promise((resolve, reject) => (this.resolvingFunctions = { resolve, reject }))
1317
}
1418

0 commit comments

Comments
 (0)