Skip to content

Refactor cookie store handling into a middleware #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seanmonstar opened this issue May 27, 2025 · 3 comments
Open

Refactor cookie store handling into a middleware #2693

seanmonstar opened this issue May 27, 2025 · 3 comments
Labels
C-refactor Category: refactor. This would improve the clarity of internal code. E-easy Effort: Easy! Start here :D E-pr-welcome The feature is welcome to be added, instruction should be found in the issue.

Comments

@seanmonstar
Copy link
Owner

There's some code duplication for storing cookies internally, it would be good to clean it up into a single place as a service middleware that both the hyper client and the h3 client can share.

@seanmonstar seanmonstar added E-easy Effort: Easy! Start here :D E-pr-welcome The feature is welcome to be added, instruction should be found in the issue. C-refactor Category: refactor. This would improve the clarity of internal code. labels May 27, 2025
@Lori-Shu
Copy link

Lori-Shu commented May 28, 2025

I noticed that a h3 client takes a cookie_store when calling new(),default async client creates a Jar as a cookie_store,do you mean extracting those lines to a function or adding a completely new struct to perform both "store" and "manage" for all cookies from all urls? @seanmonstar

@Lori-Shu
Copy link

I noticed that a h3 client takes a cookie_store when calling new(),default async client creates a Jar as a cookie_store,do you mean extracting those lines to a function or adding a completely new struct to perform both "store" and "manage" for all cookies from all urls? @seanmonstar

my solution to the latter #2701

@edilson258
Copy link

can i work on this??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-refactor Category: refactor. This would improve the clarity of internal code. E-easy Effort: Easy! Start here :D E-pr-welcome The feature is welcome to be added, instruction should be found in the issue.
Projects
None yet
Development

No branches or pull requests

3 participants