[Bug Fix + Documentation] Port count fix + Documentation updates

This PR updates our install guide to include Python,
needed for many of our scripts.

Commit log:

* scripts/*.py files updated to use python3

* hashbang reflects use of python3 in .py files

* Python dependency noted in Installation guide

* Install script edits

* syntax errors fixed

* scripts/*.py files updated to use python3

* hashbang reflects use of python3 in .py files

* Python dependency noted in Installation guide

* Install script edits

* syntax errors fixed

* fixed syntax errors

* spacing errors fixed

* addressing pylint errors

* switched exit(1) to sys.exit(1) given pylint suggestion

* cleaned up print statements

* [Bug Fix[ Fix for Manager go.sh Incorrectly Comparing Ports Available

Fixes an issue where port mask was being calculated 
incorrectly.

Commit log:

* Fixed bug in #228

* Changed dependency checking to be more OS-agnostic

* Forcing workflow rerun

* Forcing workflow rerun

* Improved dependency check

* Simplified port counting

* Added comments for port conversions

* Moved port check to prevent future merge conflict

Author: dennisafa

docs/Install.md

@@ -18,9 +18,30 @@ Check System
     your Kernel version should be higher than 2.6.33.
 
 3. Install dependencies
+
+    Install the Linux Kernel headers package for your kernel version.
     ```sh
     sudo apt-get install build-essential linux-headers-$(uname -r) git
     ```
+    If your distribution didn't come with Python or came with an earlier version, you will need to install Python 3 v3.4+. 
+
+    See if Python is already installed with
+
+    ```sh
+    python3 --version 
+    ```
+    Install Python with your distribution's package manager (Note: the command and package name may vary).
+
+    On Debian derivatives such as Ubuntu, use `apt`. Check the apt repository for the versions of Python available to you. Then, run the following command:
+    ```sh
+    sudo apt-get install python3
+    ```
+
+    Verify that Python installed correctly with
+    ```sh
+    python3 --version
+    ```
+
 4. Assure your kernel supports uio
     ```sh
     locate uio

onvm/go.sh

@@ -48,16 +48,18 @@ fi
 
 shift 3
 
-if [ -z "$nf_cores" ]
+# Verify that bc is installed
+if [[ -z $(command -v bc) ]]
 then
-    usage
+    echo "Error: bc is not installed. Install using:"
+    echo "  sudo apt-get install bc"
+    echo "See dependencies for more information"
+    exit 1
 fi
 
-ports_detected=$("$RTE_SDK"/usertools/dpdk-devbind.py --status-dev net | sed '/Network devices using kernel driver/q' | grep -c "drv")
-if [[ $ports_detected -lt $ports ]]
+if [ -z "$nf_cores" ]
 then
-    echo "Error: Invalid port mask. Insufficient NICs bound."
-    exit 1
+    usage
 fi
 
 while getopts "a:r:d:s:t:l:p:z:cv" opt; do
@@ -77,6 +79,21 @@ while getopts "a:r:d:s:t:l:p:z:cv" opt; do
     esac
 done
 
+# Convert the port mask to binary
+# Using bc where obase=2 indicates the output is base 2 and ibase=16 indicates the output is base 16
+ports_bin=$(echo "obase=2; ibase=16; $ports" | bc)
+# Splice out the 0's from the binary numbers. The result is only 1's. Example: 1011001 -> 1111
+ports_bin="${ports_bin//0/}"
+# The number of ports is the length of the string of 1's. Using above example: 1111 -> 4
+count_ports="${#ports_bin}"
+
+ports_detected=$("$RTE_SDK"/usertools/dpdk-devbind.py --status-dev net | sed '/Network devices using kernel driver/q' | grep -c "drv")
+if [[ $ports_detected -lt $count_ports ]]
+then
+    echo "Error: Invalid port mask. Insufficient NICs bound."
+    exit 1
+fi
+
 verbosity_level="-v $verbosity"
 
 # If base virtual address has not been set by the user, set to default.