Skip to content

Commit 86576ec

Browse files
committed
CI & test adjustments
1 parent 5b9754b commit 86576ec

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/workflows/tests.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
fail-fast: false
1111
matrix:
1212
os: [ubuntu-latest]
13-
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
13+
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
1414
include:
1515
- os: macos-latest
1616
python-version: "3.12"

tests/tests_asyncio/test_playwright_requests.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
TimeoutError as PlaywrightTimeoutError,
1515
)
1616
from scrapy import Spider, Request, FormRequest
17-
from scrapy.http import Response
1817

1918
from scrapy_playwright.handler import DEFAULT_CONTEXT_NAME
2019
from scrapy_playwright.page import PageMethod
@@ -28,7 +27,7 @@ class DialogSpider(Spider):
2827

2928
name = "dialog"
3029

31-
def parse(self, response: Response, **kwargs) -> None:
30+
def parse(self, **_kwargs) -> None:
3231
return None
3332

3433
async def handle_dialog(self, dialog: Dialog) -> None:
@@ -37,6 +36,8 @@ async def handle_dialog(self, dialog: Dialog) -> None:
3736

3837

3938
class MixinTestCase:
39+
browser_type: str
40+
4041
@pytest.fixture(autouse=True)
4142
def inject_fixtures(self, caplog):
4243
caplog.set_level(logging.DEBUG)

0 commit comments

Comments
 (0)