Skip to content

fix: add the v prefix to the tag name for express #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

fix: add the v prefix to the tag name for express #481

merged 1 commit into from
Apr 22, 2025

Conversation

lholmquist
Copy link
Member

@lholmquist lholmquist commented Apr 18, 2025 •
edited by github-actions bot
Loading

Previous to version 5.1.0 of express, there was no usage of a prefix before the label. I did ask the question here: expressjs/express#6467 if there will be consistency going forward

@lholmquist
fix: add the v prefix to the tag name for express.js
5515748 
Previous to version 5.1.0, there was no usage of a prefix before the label.  I did ask the question here: expressjs/express#6467 if there will be consistency going forward
@lholmquist lholmquist force-pushed the update-express-tag-label branch from b0b15be to 5515748 Compare April 18, 2025 15:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

Pull Request validation

Failed

🔴 Failed or pending statuses - Testing Farm - RHEL10 - UpstreamTests - 22-minimal[error],Testing Farm - RHEL10 - 22-minimal[error],Testing Farm - RHEL10 - UpstreamTests - 22[error],Testing Farm - Fedora - 18[error],Testing Farm - RHEL9 - UpstreamTests - 18[error],Testing Farm - RHEL9 - UpstreamTests - 22[error],Testing Farm - Fedora - 20[error],Testing Farm - RHEL9 - UpstreamTests - 20[error],Testing Farm - CentOS Stream 10 - 22[error],Testing Farm - CentOS Stream 9 - 20[error],Testing Farm - RHEL10 - 22[error],Testing Farm - RHEL8 - UpstreamTests - 18[error],Testing Farm - RHEL8 - UpstreamTests - 22[error],Testing Farm - RHEL8 - UpstreamTests - 20[error]
🔴 Review - Missing review from a member (1 required)

@phracek

This comment was marked as outdated.

Sign in to view
@phracek

This comment was marked as outdated.

Sign in to view
@phracek
Copy link
Member

phracek commented Apr 22, 2025

[test-upstream][test]

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 22, 2025 •
edited
Loading

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
CentOS Stream 10 - 22CentOS-Stream-10x86_64❌ error22.04.2025 08:21:4618min 19stest pipeline
Fedora - 18-minimalFedora-latestx86_64✅ passed22.04.2025 07:58:529min 16stest pipeline
Fedora - 18Fedora-latestx86_64❌ error22.04.2025 07:58:5025min 16stest pipeline
Fedora - 20Fedora-latestx86_64❌ error22.04.2025 08:11:2326min 45stest pipeline
CentOS Stream 10 - 22-minimalCentOS-Stream-10x86_64✅ passed22.04.2025 08:29:286min 28stest pipeline
RHEL8 - UpstreamTests - 18-minimalRHEL-8.10.0-Nightlyx86_64✅ passed22.04.2025 07:58:1917min 58stest pipeline
RHEL10 - UpstreamTests - 22-minimalRHEL-10-Nightlyx86_64❌ error22.04.2025 07:59:0518min 40stest pipeline
RHEL10 - 22-minimalRHEL-10-Nightlyx86_64❌ error22.04.2025 07:59:1419min 12stest pipeline
RHEL8 - 18-minimalRHEL-8.10.0-Nightlyx86_64✅ passed22.04.2025 07:58:2720min 36stest pipeline
RHEL10 - UpstreamTests - 22RHEL-10-Nightlyx86_64❌ error22.04.2025 07:59:3219min 20stest pipeline
RHEL8 - 20RHEL-8.10.0-Nightlyx86_64✅ passed22.04.2025 07:58:5220min 59stest pipeline
CentOS Stream 9 - 20CentOS-Stream-9x86_64❌ error22.04.2025 08:20:5219min 39stest pipeline
Fedora - 22Fedora-latestx86_64✅ passed22.04.2025 08:20:3210min 22stest pipeline
RHEL9 - UpstreamTests - 20-minimalRHEL-9.4.0-Nightlyx86_64✅ passed22.04.2025 07:59:3320min 49stest pipeline
RHEL8 - UpstreamTests - 20-minimalRHEL-8.10.0-Nightlyx86_64✅ passed22.04.2025 07:59:0521min 46stest pipeline
RHEL8 - 20-minimalRHEL-8.10.0-Nightlyx86_64✅ passed22.04.2025 07:59:1023min 20stest pipeline
RHEL8 - 18RHEL-8.10.0-Nightlyx86_64✅ passed22.04.2025 07:59:1724min 32stest pipeline
RHEL8 - UpstreamTests - 22-minimalRHEL-8.10.0-Nightlyx86_64✅ passed22.04.2025 08:07:0818min 54stest pipeline
RHEL9 - UpstreamTests - 18RHEL-9.4.0-Nightlyx86_64❌ error22.04.2025 07:58:2127min 38stest pipeline
CentOS Stream 9 - 20-minimalCentOS-Stream-9x86_64✅ passed22.04.2025 08:27:106min 17stest pipeline
Fedora - 20-minimalFedora-latestx86_64✅ passed22.04.2025 08:23:099min 9stest pipeline
RHEL9 - 18RHEL-9.4.0-Nightlyx86_64✅ passed22.04.2025 08:08:5119min 12stest pipeline
Fedora - 22-minimalFedora-latestx86_64✅ passed22.04.2025 08:33:228min 50stest pipeline
RHEL8 - 22RHEL-8.10.0-Nightlyx86_64✅ passed22.04.2025 08:13:2119min 35stest pipeline
RHEL9 - UpstreamTests - 22RHEL-9.4.0-Nightlyx86_64❌ error22.04.2025 07:58:2035min 33stest pipeline
RHEL9 - UpstreamTests - 22-minimalRHEL-9.4.0-Nightlyx86_64✅ passed22.04.2025 08:19:3616min 25stest pipeline
RHEL9 - 20RHEL-9.4.0-Nightlyx86_64✅ passed22.04.2025 08:16:5019min 47stest pipeline
RHEL9 - UpstreamTests - 20RHEL-9.4.0-Nightlyx86_64❌ error22.04.2025 07:59:2038min 58stest pipeline
RHEL9 - UpstreamTests - 18-minimalRHEL-9.4.0-Nightlyx86_64✅ passed22.04.2025 08:24:4516min 9stest pipeline
RHEL10 - 22RHEL-10-Nightlyx86_64❌ error22.04.2025 08:28:3613min 13stest pipeline
RHEL8 - 22-minimalRHEL-8.10.0-Nightlyx86_64✅ passed22.04.2025 08:24:1220min 24stest pipeline
RHEL9 - 20-minimalRHEL-9.4.0-Nightlyx86_64✅ passed22.04.2025 08:28:0318min 36stest pipeline
RHEL9 - 22-minimalRHEL-9.4.0-Nightlyx86_64✅ passed22.04.2025 08:29:2118min 37stest pipeline
RHEL8 - UpstreamTests - 18RHEL-8.10.0-Nightlyx86_64❌ error22.04.2025 08:26:3827min 20stest pipeline
RHEL9 - 18-minimalRHEL-9.4.0-Nightlyx86_64✅ passed22.04.2025 08:33:1420min 58stest pipeline
RHEL9 - 22RHEL-9.4.0-Nightlyx86_64✅ passed22.04.2025 08:31:3623min 1stest pipeline
RHEL8 - UpstreamTests - 22RHEL-8.10.0-Nightlyx86_64❌ error22.04.2025 08:18:3437min 31stest pipeline
RHEL8 - UpstreamTests - 20RHEL-8.10.0-Nightlyx86_64❌ error22.04.2025 08:19:2637min 15stest pipeline

phracek
phracek approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this easy fix. I went through all logs and express is fully passing. Great job.

@phracek phracek merged commit 4526149 into sclorg:master Apr 22, 2025
25 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phracek phracek phracek approved these changes

Assignees
No one assigned
Labels
pr/failing-ci pr/missing-review READY-to-MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lholmquist @phracek