Skip to content

Commit c413ec5

Browse files
committed
Fix Dockerfiles for using nodejs22 package
Signed-off-by: Petr "Stone" Hracek <[email protected]>
1 parent 6f22b17 commit c413ec5

File tree

4 files changed

+6
-14
lines changed

4 files changed

+6
-14
lines changed

22-minimal/Dockerfile.c10s

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ LABEL summary="$SUMMARY" \
4949
help="For more information visit https://github.com/sclorg/s2i-nodejs-container"
5050

5151
# nodejs-full-i18n is included for error strings
52-
RUN INSTALL_PKGS="nodejs nodejs-nodemon nodejs-full-i18n npm findutils tar which" && \
52+
RUN INSTALL_PKGS="nodejs$NODEJS_VERSION nodejs-nodemon nodejs$NODEJS_VERSION-full-i18n npm findutils tar which" && \
5353
dnf -y --nodocs --setopt=install_weak_deps=0 install $INSTALL_PKGS && \
54-
node -v | grep -qe "^v$NODEJS_VERSION\." && echo "Found VERSION $NODEJS_VERSION" && \
54+
node-22 -v | grep -qe "^v$NODEJS_VERSION\." && echo "Found VERSION $NODEJS_VERSION" && \
5555
dnf clean all && \
5656
rm -rf /mnt/rootfs/var/cache/* /mnt/rootfs/var/log/dnf* /mnt/rootfs/var/log/yum.*
5757

22-minimal/Dockerfile.fedora

+1-5
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,7 @@ LABEL summary="$SUMMARY" \
5252
RUN INSTALL_PKGS="nodejs$NODEJS_VERSION nodejs-nodemon nodejs$NODEJS_VERSION-full-i18n nodejs$NODEJS_VERSION-npm findutils tar which nss_wrapper-libs" && \
5353
microdnf -y --nodocs --setopt=install_weak_deps=0 install $INSTALL_PKGS && \
5454
microdnf clean all && \
55-
ln -s /usr/bin/node-$NODEJS_VERSION /usr/bin/node && \
56-
ln -s /usr/bin/npm-$NODEJS_VERSION /usr/bin/npm && \
57-
ln -s /usr/bin/npx-$NODEJS_VERSION /usr/bin/npx && \
58-
ln -s /usr/lib/node_modules_18/nodemon /usr/lib/node_modules_$NODEJS_VERSION/nodemon && \
59-
node -v | grep -qe "^v$NODEJS_VERSION\." && echo "Found VERSION $NODEJS_VERSION" && \
55+
node-22 -v | grep -qe "^v$NODEJS_VERSION\." && echo "Found VERSION $NODEJS_VERSION" && \
6056
rm -rf /mnt/rootfs/var/cache/* /mnt/rootfs/var/log/dnf* /mnt/rootfs/var/log/yum.*
6157

6258
#

22/Dockerfile.c10s

+2-2
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,10 @@ LABEL summary="$SUMMARY" \
5454
usage="s2i build <SOURCE-REPOSITORY> quay.io/sclorg/$NAME-$NODEJS_VERSION-c10s:latest <APP-NAME>"
5555

5656
# Package libatomic_ops was removed
57-
RUN INSTALL_PKGS="make gcc gcc-c++ git openssl-devel nodejs npm nodejs-nodemon nss_wrapper-libs which" && \
57+
RUN INSTALL_PKGS="make gcc gcc-c++ libatomic_ops git openssl-devel nodejs$NODEJS_VERSION nodejs-nodemon nodejs$NODEJS_VERSION-npm nss_wrapper-libs which" && \
5858
dnf install -y --setopt=tsflags=nodocs $INSTALL_PKGS && \
5959
rpm -V $INSTALL_PKGS && \
60-
node -v | grep -qe "^v$NODEJS_VERSION\." && echo "Found VERSION $NODEJS_VERSION" && \
60+
node-22 -v | grep -qe "^v$NODEJS_VERSION\." && echo "Found VERSION $NODEJS_VERSION" && \
6161
dnf -y clean all --enablerepo='*'
6262

6363
# Copy the S2I scripts from the specific language image to $STI_SCRIPTS_PATH

22/Dockerfile.fedora

+1-5
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,7 @@ LABEL summary="$SUMMARY" \
5151
RUN INSTALL_PKGS="make gcc gcc-c++ libatomic_ops git openssl-devel nodejs$NODEJS_VERSION nodejs-nodemon nodejs$NODEJS_VERSION-npm nss_wrapper-libs which" && \
5252
dnf install -y --setopt=tsflags=nodocs $INSTALL_PKGS && \
5353
rpm -V $INSTALL_PKGS && \
54-
ln -s /usr/bin/node-$NODEJS_VERSION /usr/bin/node && \
55-
ln -s /usr/bin/npm-$NODEJS_VERSION /usr/bin/npm && \
56-
ln -s /usr/bin/npx-$NODEJS_VERSION /usr/bin/npx && \
57-
ln -s /usr/lib/node_modules_18/nodemon /usr/lib/node_modules_$NODEJS_VERSION/nodemon && \
58-
node -v | grep -qe "^v$NODEJS_VERSION\." && echo "Found VERSION $NODEJS_VERSION" && \
54+
node-22 -v | grep -qe "^v$NODEJS_VERSION\." && echo "Found VERSION $NODEJS_VERSION" && \
5955
dnf -y clean all --enablerepo='*'
6056

6157
# Copy the S2I scripts from the specific language image to $STI_SCRIPTS_PATH

0 commit comments

Comments
 (0)