Skip to content

Commit b22448c

Browse files
authored
Fix open files (#421)
* Change Dockerfile in examples/from-dockerfile dir Bump FROM directive Change also expected output in ct_test_app_dockerfile * Fix too many files during the build by adding --ulimit nofile=4096:4096 Signed-off-by: Petr "Stone" Hracek <[email protected]>
1 parent f0304ed commit b22448c

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

common

Submodule common updated 1 file

examples/from-dockerfile/Dockerfile

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1-
FROM registry.access.redhat.com/ubi8/nodejs-14
1+
FROM registry.access.redhat.com/ubi8/nodejs-16
22

33
# Add application sources
44
ADD app-src .
55

66
# In case you run into permission errors during build (eg. by use of umask)
77
# running the fix-permission script will make sure all bits are as expected by the image
8-
# USER 0
9-
# RUN fix-permissions ./
10-
# USER 1001
8+
USER 0
9+
RUN fix-permissions ./
10+
USER 1001
1111

1212
# Install the dependencies
1313
RUN npm install

examples/from-dockerfile/Dockerfile.s2i

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM registry.access.redhat.com/ubi8/nodejs-14
1+
FROM registry.access.redhat.com/ubi8/nodejs-16
22

33
# This image supports the Source-to-Image
44
# (see more at https://docs.openshift.com/container-platform/3.11/creating_images/s2i.html).

test/test-lib-nodejs.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -426,9 +426,9 @@ function test_client_fastify() {
426426

427427
function test_check_build_using_dockerfile() {
428428
info "Check building using a Dockerfile"
429-
ct_test_app_dockerfile ${THISDIR}/examples/from-dockerfile/Dockerfile 'https://github.com/sclorg/nodejs-ex.git' 'Welcome to your Node.js application on OpenShift' app-src
429+
ct_test_app_dockerfile ${THISDIR}/examples/from-dockerfile/Dockerfile 'https://github.com/sclorg/nodejs-ex.git' 'Node.js Crud Application' app-src "--ulimit nofile=4096:4096"
430430
ct_check_testcase_result $?
431-
ct_test_app_dockerfile ${THISDIR}/examples/from-dockerfile/Dockerfile.s2i 'https://github.com/sclorg/nodejs-ex.git' 'Welcome to your Node.js application on OpenShift' app-src
431+
ct_test_app_dockerfile ${THISDIR}/examples/from-dockerfile/Dockerfile.s2i 'https://github.com/sclorg/nodejs-ex.git' 'Node.js Crud Application' app-src "--ulimit nofile=4096:4096"
432432
ct_check_testcase_result $?
433433
}
434434
function test_npm_functionality() {

0 commit comments

Comments
 (0)