Skip to content

Countdown module's colors make the direction of the countdown difficult to determine. #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
micahstubbs opened this issue Apr 24, 2020 · 2 comments
Assignees

Comments

@micahstubbs
Copy link
Contributor

The progress bar direction should match the direction of the text for the language specified in the user-agent.

So, for "en-us", the language is English, for which the direction of the text is left-to-right (LTR). So then, the direction of the linear progress at the bottom of the countdown notification should also be LTR.

https://stackoverflow.com/questions/673905/best-way-to-determine-users-locale-within-browser

https://developer.mozilla.org/en-US/docs/Web/API/NavigatorLanguage/language

@micahstubbs
Copy link
Contributor Author

We can observe the current RTL behavior of the Countdown notification type on the demos page https://sciactive.com/pnotify/#demos-modules

@hperrin
Copy link
Member

hperrin commented Apr 24, 2020

It's counting down, so it's going from 100% to 0%. The progress bar is LTR, which you can see when it counts back up after putting your cursor over it.

I think the confusion here may be that the progress bar's color is the same as the background color of the notice, and its background color is the same as the border color of the notice.

I can make an option to swap the colors.

@hperrin hperrin changed the title countdown linear-progress direction should match users's language text direction Countdown module's colors make the direction of the countdown difficult to determine. Apr 24, 2020
@hperrin hperrin self-assigned this Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants