Skip to content

Check for supported dtypes when adding new mag #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hotzenklotz opened this issue Apr 12, 2023 · 1 comment
Open

Check for supported dtypes when adding new mag #894

hotzenklotz opened this issue Apr 12, 2023 · 1 comment

Comments

@hotzenklotz
Copy link
Member

hotzenklotz commented Apr 12, 2023

Detailed Description

  • Affected library: webknossos

When adding a new mag / adding data to a layer, we should assert that the data's dtype is actually supported by WEBKNOSSOS and can be rendered. If not, provide a warning.

Probably should be handled by the mag.write() method or when creating a new layer.

Supported dtypes can be found: https://docs.webknossos.org/webknossos/data_formats.html#wkw-datasets or at scalableminds/webknossos#6581

Use Cases & Context

This could prevent user errors, e.g. uploading color layer data as uint64.

@philippotto
Copy link
Member

The amount of supported dtypes got way larger with scalableminds/webknossos#8325, but there are still some obscure formats that are not supported. Namely, (u)int64 and double are not supported for color layers. Segmentation layers don't support float and double (somewhat logical).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants