Skip to content

Commit 002dc29

Browse files
author
Logan Graham
committed
add diffingOptions to playwright SDK
1 parent 291ce2a commit 002dc29

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

visual-js/visual-playwright/src/api.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,7 @@ ${e instanceof Error ? e.message : JSON.stringify(e)}
160160
diffingMethod,
161161
diffingMethodTolerance,
162162
diffingMethodSensitivity,
163+
diffingOptions,
163164
} = options ?? {};
164165
const {
165166
animations = 'disabled',
@@ -337,6 +338,7 @@ ${e instanceof Error ? e.message : JSON.stringify(e)}
337338
diffingMethod,
338339
diffingMethodSensitivity,
339340
diffingMethodTolerance,
341+
diffingOptions,
340342
});
341343

342344
const { diffs } = await this.api.createSnapshot({

visual-js/visual-playwright/src/types.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import {
22
DiffingMethod,
33
DiffingMethodSensitivity,
44
DiffingMethodToleranceIn,
5+
DiffingOptionsIn,
56
RegionIn,
67
VisualEnvOpts,
78
} from '@saucelabs/visual';
@@ -35,6 +36,7 @@ export interface SauceVisualParams {
3536
diffingMethod?: DiffingMethod;
3637
diffingMethodTolerance?: DiffingMethodToleranceIn;
3738
diffingMethodSensitivity?: DiffingMethodSensitivity;
39+
diffingOptions?: DiffingOptionsIn;
3840
}
3941

4042
export interface PlaywrightEnvOpts extends VisualEnvOpts {

visual-js/visual-playwright/src/utils.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import {
33
DiffingMethod,
44
DiffingMethodSensitivity,
55
DiffingMethodToleranceIn,
6+
DiffingOptionsIn,
67
getEnvOpts,
78
OperatingSystem,
89
SnapshotIn,
@@ -110,6 +111,7 @@ export const buildSnapshotMetadata = ({
110111
diffingMethod,
111112
diffingMethodTolerance,
112113
diffingMethodSensitivity,
114+
diffingOptions,
113115
}: {
114116
browserName: string | undefined;
115117
browserVersion: string | undefined;
@@ -119,13 +121,15 @@ export const buildSnapshotMetadata = ({
119121
name: string;
120122
ignoreRegions: SnapshotIn['ignoreRegions'];
121123
diffingMethod: DiffingMethod | undefined;
122-
diffingMethodTolerance?: DiffingMethodToleranceIn;
123-
diffingMethodSensitivity?: DiffingMethodSensitivity;
124+
diffingMethodTolerance: DiffingMethodToleranceIn | undefined;
125+
diffingMethodSensitivity: DiffingMethodSensitivity | undefined;
126+
diffingOptions: DiffingOptionsIn | undefined;
124127
}): Omit<SnapshotIn, 'uploadId'> => {
125128
return {
126129
diffingMethod: diffingMethod || DiffingMethod.Balanced,
127130
diffingMethodTolerance,
128131
diffingMethodSensitivity,
132+
diffingOptions,
129133
browser: getKnownBrowserType(browserName),
130134
browserVersion: browserVersion ? `Playwright - ${browserVersion}` : null,
131135
buildUuid: buildId,

0 commit comments

Comments
 (0)