Skip to content

Commit e2b93b5

Browse files
committed
Remove unnecessary synchronized code blocks [ci skip]
1 parent 6d68885 commit e2b93b5

File tree

1 file changed

+6
-9
lines changed
  • webcam-capture/src/main/java/com/github/sarxos/webcam

1 file changed

+6
-9
lines changed

webcam-capture/src/main/java/com/github/sarxos/webcam/Webcam.java

+6-9
Original file line numberDiff line numberDiff line change
@@ -439,18 +439,14 @@ public boolean addWebcamListener(WebcamListener l) {
439439
if (l == null) {
440440
throw new IllegalArgumentException("Webcam listener cannot be null!");
441441
}
442-
synchronized (listeners) {
443-
return listeners.add(l);
444-
}
442+
return listeners.add(l);
445443
}
446444

447445
/**
448446
* @return All webcam listeners
449447
*/
450448
public WebcamListener[] getWebcamListeners() {
451-
synchronized (listeners) {
452-
return listeners.toArray(new WebcamListener[listeners.size()]);
453-
}
449+
return listeners.toArray(new WebcamListener[listeners.size()]);
454450
}
455451

456452
/**
@@ -460,9 +456,7 @@ public WebcamListener[] getWebcamListeners() {
460456
* @return True if listener has been removed, false otherwise
461457
*/
462458
public boolean removeWebcamListener(WebcamListener l) {
463-
synchronized (listeners) {
464-
return listeners.remove(l);
465-
}
459+
return listeners.remove(l);
466460
}
467461

468462
/**
@@ -649,6 +643,9 @@ public static boolean isHandleTermSignal() {
649643
* @return True, if listeners list size has been changed, false otherwise
650644
*/
651645
public static boolean addDiscoveryListener(WebcamDiscoveryListener l) {
646+
if (l == null) {
647+
throw new IllegalArgumentException("Webcam discovery listener cannot be null!");
648+
}
652649
return DISCOVERY_LISTENERS.add(l);
653650
}
654651

0 commit comments

Comments
 (0)