Skip to content

Commit 7b4f699

Browse files
samaityzhenggen-xu
authored andcommitted
Click Upgrade to 7.0.0 (sonic-net#20)
Signed-off-by: Sangita Maity <[email protected]>
1 parent 08b5cd4 commit 7b4f699

File tree

7 files changed

+4
-50
lines changed

7 files changed

+4
-50
lines changed

.gitignore

-2
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,6 @@ src/lm-sensors/*
6262
!src/lm-sensors/Makefile
6363
src/mpdecimal/*
6464
!src/mpdecimal/Makefile
65-
src/python-click/*
66-
!src/python-click/Makefile
6765
src/python3/*
6866
!src/python3/Makefile
6967
src/radvd/*

files/build_templates/sonic_debian_extension.j2

+2-2
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,8 @@ sudo rm -rf $FILESYSTEM_ROOT/$DAEMON_BASE_PY2_WHEEL_NAME
134134
# Install built Python Click package (and its dependencies via 'apt-get -y install -f')
135135
# Do this before installing sonic-utilities so that it doesn't attempt to install
136136
# an older version as part of its dependencies
137-
sudo dpkg --root=$FILESYSTEM_ROOT -i $debs_path/python-click*_all.deb || \
138-
sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y install -f
137+
# Install click == 7.0.0 via pip in order to support autocompletion for breakout Mode in sonic-utilities
138+
sudo https_proxy=$https_proxy LANG=C chroot $FILESYSTEM_ROOT pip install click==7.0.0
139139

140140
# Install python pexpect used by sonic-utilities consutil
141141
# using pip install instead to get a more recent version than is available through debian

rules/python-click.mk

-17
This file was deleted.

slave.mk

-1
Original file line numberDiff line numberDiff line change
@@ -613,7 +613,6 @@ $(addprefix $(TARGET_PATH)/, $(SONIC_INSTALLERS)) : $(TARGET_PATH)/% : \
613613
$(addprefix $(STRETCH_DEBS_PATH)/,$(INITRAMFS_TOOLS) \
614614
$(LINUX_KERNEL) \
615615
$(SONIC_DEVICE_DATA) \
616-
$(PYTHON_CLICK) \
617616
$(IFUPDOWN2) \
618617
$(KDUMP_TOOLS) \
619618
$(LIBPAM_TACPLUS) \

sonic-slave-jessie/Dockerfile.j2

+1-1
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ RUN pip install --force-reinstall --upgrade "jinja2>=2.10"
307307
RUN pip install j2cli==0.3.10
308308

309309
# For sonic utilities testing
310-
RUN pip install click-default-group click natsort tabulate netifaces==0.10.7 fastentrypoints
310+
RUN pip install click-default-group click==7.0.0 natsort tabulate netifaces==0.10.7 fastentrypoints
311311

312312
# For supervisor build
313313
RUN pip install meld3 mock

sonic-slave-stretch/Dockerfile.j2

+1-1
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ RUN pip install j2cli==0.3.10
331331
# Remove python-click 6.6
332332
RUN apt-get purge -y python-click
333333
# For sonic utilities testing
334-
RUN pip install click-default-group click natsort tabulate netifaces==0.10.7 fastentrypoints
334+
RUN pip install click-default-group click==7.0.0 natsort tabulate netifaces==0.10.7 fastentrypoints
335335

336336
# For sonic snmpagent mock testing
337337
RUN pip3 install mockredispy==2.9.3

src/python-click/Makefile

-26
This file was deleted.

0 commit comments

Comments
 (0)