try to fix test fail

Author: naorpeled

alchemy/src/aws/vpc.ts

@@ -3,8 +3,9 @@ import {
   DeleteVpcCommand,
   DescribeVpcsCommand,
   EC2Client,
-  ResourceNotFoundException,
+  ResourceType,
   type Tag,
+  type TagSpecification,
 } from "@aws-sdk/client-ec2";
 import type { Context } from "../context";
 import { Resource } from "../resource";
@@ -219,7 +220,7 @@ export const Vpc = Resource(
     if (this.phase === "delete") {
       try {
         if (this.output?.id) {
-          await ignore(ResourceNotFoundException.name, () =>
+          await ignore("VpcNotFound", () =>
             client.send(
               new DeleteVpcCommand({
                 VpcId: this.output.id,
@@ -235,7 +236,7 @@ export const Vpc = Resource(
     } else {
       try {
         // Format tags for AWS API
-        const tagSpecifications = [];
+        const tagSpecifications: TagSpecification[] = [];
         const tags: Tag[] = [];
 
         if (props.name) {
@@ -256,7 +257,7 @@ export const Vpc = Resource(
 
         if (tags.length > 0) {
           tagSpecifications.push({
-            ResourceType: "vpc",
+            ResourceType: ResourceType.vpc,
             Tags: tags,
           });
         }

alchemy/test/aws/vpc.test.ts

@@ -74,16 +74,15 @@ describe("Vpc Resource", () => {
           // Check if it's in a terminated state or gone from the response
           if (getDeletedResponse.Vpcs && getDeletedResponse.Vpcs.length > 0) {
             const deletedVpc = getDeletedResponse.Vpcs[0];
-            expect(deletedVpc.State).toEqual("pending-delete");
+            // VPC states are "available" or "pending"
+            expect(deletedVpc.State).toEqual("pending");
           } else {
             // VPC was successfully deleted
             expect(getDeletedResponse.Vpcs?.length).toEqual(0);
           }
         } catch (error: any) {
           // The describe call should fail with a not found error
-          expect(error.name).toMatch(
-            /VpcNotFound|InvalidVpcId|ResourceNotFoundException/
-          );
+          expect(error.name).toMatch(/VpcNotFound/);
         }
       }
     }