Enable recommended eslint rules (#1823)

krzysztofzuraw · web-flow · commit 6ec72faadccf · 2025-03-28T14:03:09.000+01:00
diff --git a/apps/avatax/eslint.config.js b/apps/avatax/eslint.config.js
@@ -27,6 +27,18 @@ export default [
       ],
     },
   },
+  {
+    // TODO: remove this override once the recommended rules are fixed
+    name: "saleor-app-avatax/override-recommended",
+    files: ["**/*.{ts,tsx}"],
+    rules: {
+      "@typescript-eslint/no-empty-object-type": "warn",
+      "@typescript-eslint/no-unused-vars": "warn",
+      "@typescript-eslint/no-explicit-any": "warn",
+      "@typescript-eslint/no-unnecessary-type-constraint": "warn",
+      "no-fallthrough": "warn",
+    },
+  },
   {
     name: "saleor-app-avatax/override-no-process-env",
     files: ["next.config.ts", "src/env.ts", "src/instrumentation.ts"],
diff --git a/apps/avatax/src/modules/avatax/avatax-client-tax-code.service.test.ts b/apps/avatax/src/modules/avatax/avatax-client-tax-code.service.test.ts
@@ -7,14 +7,14 @@ import { AvataxForbiddenAccessError } from "../taxes/tax-error";
 
 describe("AvataxClientTaxCodeService", () => {
   describe("getFilteredTaxCodes", () => {
-    it("Throws ForbiddenAccessError error if Avatax returns AvataxForbiddenAccessError", () => {
+    it("Throws ForbiddenAccessError error if Avatax returns AvataxForbiddenAccessError", async () => {
       const service = new AvataxClientTaxCodeService({
         listTaxCodes() {
           return Promise.resolve(err(new AvataxForbiddenAccessError("Not permitted")));
         },
       });
 
-      expect(() => service.getFilteredTaxCodes({ filter: "" })).rejects.toThrowError(
+      await expect(() => service.getFilteredTaxCodes({ filter: "" })).rejects.toThrowError(
         AvataxClientTaxCodeService.ForbiddenAccessError,
       );
     });
diff --git a/apps/avatax/src/modules/avatax/order-confirmed/saleor-order-to-avatax-lines-transformer.test.ts b/apps/avatax/src/modules/avatax/order-confirmed/saleor-order-to-avatax-lines-transformer.test.ts
@@ -14,7 +14,7 @@ const saleorConfirmedOrderEvent = SaleorOrderConfirmedEventMockFactory.create();
 const discountsStrategy = new PriceReductionDiscountsStrategy();
 
 describe("SaleorOrderToAvataxLinesTransformer", () => {
-  it("should transform lines and shipping from order into product and shipping lines ", () => {
+  it("should transform lines and shipping from order into product and shipping lines", () => {
     const { order } = SaleorOrderConfirmedEventMockFactory.getGraphqlPayload();
 
     expect(
diff --git a/apps/cms/eslint.config.js b/apps/cms/eslint.config.js
@@ -1,4 +1,21 @@
 import { config } from "@saleor/eslint-config-apps/index.js";
 
 /** @type {import("eslint").Linter.Config} */
-export default config;
+export default [
+  ...config,
+  {
+    // TODO: remove this override once the recommended rules are fixed
+    name: "saleor-app-cms/override-recommended",
+    files: ["**/*.{ts,tsx}"],
+    rules: {
+      "@typescript-eslint/no-unused-vars": "warn",
+      "@typescript-eslint/no-unused-expressions": "warn",
+      "@typescript-eslint/no-empty-object-type": "warn",
+      "@typescript-eslint/no-explicit-any": "warn",
+      "@typescript-eslint/no-namespace": "warn",
+      "@typescript-eslint/no-require-imports": "warn",
+      "@typescript-eslint/no-non-null-asserted-optional-chain": "warn",
+      "no-fallthrough": "warn",
+    },
+  },
+];
diff --git a/apps/klaviyo/eslint.config.js b/apps/klaviyo/eslint.config.js
@@ -1,4 +1,18 @@
 import { config } from "@saleor/eslint-config-apps/index.js";
 
 /** @type {import("eslint").Linter.Config} */
-export default config;
+export default [
+  ...config,
+  {
+    // TODO: remove this override once the recommended rules are fixed
+    name: "saleor-app-klaviyo/override-recommended",
+    files: ["**/*.{ts,tsx}"],
+    rules: {
+      "@typescript-eslint/no-empty-object-type": "warn",
+      "@typescript-eslint/no-explicit-any": "warn",
+      "no-constant-binary-expression": "warn",
+      "@typescript-eslint/no-require-imports": "warn",
+      "@typescript-eslint/no-non-null-asserted-optional-chain": "warn",
+    },
+  },
+];
diff --git a/apps/products-feed/eslint.config.js b/apps/products-feed/eslint.config.js
@@ -1,4 +1,20 @@
 import { config } from "@saleor/eslint-config-apps/index.js";
 
 /** @type {import("eslint").Linter.Config} */
-export default config;
+export default [
+  ...config,
+  {
+    // TODO: remove this override once the recommended rules are fixed
+    name: "saleor-app-products-feed/override-recommended",
+    files: ["**/*.{ts,tsx}"],
+    rules: {
+      "@typescript-eslint/no-unused-vars": "warn",
+      "no-empty": "warn",
+      "@typescript-eslint/ban-ts-comment": "warn",
+      "@typescript-eslint/no-empty-object-type": "warn",
+      "@typescript-eslint/no-unused-expressions": "warn",
+      "@typescript-eslint/no-explicit-any": "warn",
+      "@typescript-eslint/no-require-imports": "warn",
+    },
+  },
+];
diff --git a/apps/products-feed/src/modules/app-configuration/attribute-fetcher.ts b/apps/products-feed/src/modules/app-configuration/attribute-fetcher.ts
@@ -45,7 +45,7 @@ export class AttributeFetcher {
    * Fetches all attribute pages - standard page is max 100 items
    */
   async fetchAllAttributes(): Promise<AttributeWithMappingFragmentFragment[]> {
-    let attributes: AttributeWithMappingFragmentFragment[] = [];
+    const attributes: AttributeWithMappingFragmentFragment[] = [];
 
     this.logger.debug("fetchAllAttributes called");
 
diff --git a/apps/products-feed/src/modules/category-mapping/categories-fetcher.ts b/apps/products-feed/src/modules/category-mapping/categories-fetcher.ts
@@ -46,7 +46,7 @@ export class CategoriesFetcher {
    * Fetches all categories pages - standard page is max 100 items
    */
   async fetchAllCategories(): Promise<CategoryWithMappingFragmentFragment[]> {
-    let categories: CategoryWithMappingFragmentFragment[] = [];
+    const categories: CategoryWithMappingFragmentFragment[] = [];
 
     this.logger.debug("fetchAllCategories called");
 
diff --git a/apps/products-feed/src/modules/google-feed/fetch-product-data.test.ts b/apps/products-feed/src/modules/google-feed/fetch-product-data.test.ts
@@ -9,7 +9,7 @@ import {
 import { fetchProductData, getCursors } from "./fetch-product-data";
 
 describe("getCursors", () => {
-  it("loads cursor for each variant page ", async () => {
+  it("loads cursor for each variant page", async () => {
     const client = {
       query: vi.fn().mockReturnValue({
         toPromise: vi
diff --git a/apps/search/eslint.config.js b/apps/search/eslint.config.js
@@ -1,4 +1,19 @@
 import { config } from "@saleor/eslint-config-apps/index.js";
 
 /** @type {import("eslint").Linter.Config} */
-export default config;
+export default [
+  ...config,
+  {
+    // TODO: remove this override once the recommended rules are fixed
+    name: "saleor-app-search/override-recommended",
+    files: ["**/*.{ts,tsx}"],
+    rules: {
+      "@typescript-eslint/no-unused-vars": "warn",
+      "@typescript-eslint/ban-ts-comment": "warn",
+      "@typescript-eslint/no-empty-object-type": "warn",
+      "@typescript-eslint/no-non-null-asserted-optional-chain": "warn",
+      "@typescript-eslint/no-explicit-any": "warn",
+      "@typescript-eslint/no-require-imports": "warn",
+    },
+  },
+];
diff --git a/apps/segment/eslint.config.js b/apps/segment/eslint.config.js
@@ -21,4 +21,15 @@ export default [
       "n/no-process-env": "off",
     },
   },
+  {
+    // TODO: remove this override once the recommended rules are fixed
+    name: "saleor-app-search/override-recommended",
+    files: ["**/*.{ts,tsx}"],
+    rules: {
+      "no-fallthrough": "warn",
+      "@typescript-eslint/no-unused-vars": "warn",
+      "@typescript-eslint/no-namespace": "warn",
+      "@typescript-eslint/no-empty-object-type": "warn",
+    },
+  },
 ];
diff --git a/apps/segment/src/modules/configuration/dynamo-app-config-manager.test.ts b/apps/segment/src/modules/configuration/dynamo-app-config-manager.test.ts
@@ -40,17 +40,17 @@ describe("DynamoAppConfigManager", () => {
     expect(result).toBeNull();
   });
 
-  it("should throw error if getting App Config fails", () => {
+  it("should throw error if getting App Config fails", async () => {
     const repository = new MemoryConfigRepository();
 
     vi.spyOn(repository, "getAppConfigEntry").mockReturnValue(
       Promise.resolve(err(new DynamoAppConfigManager.GetConfigDataError("Error getting data"))),
     );
     const manager = DynamoAppConfigManager.create(repository);
 
-    expect(manager.get({ appId: "appId", saleorApiUrl: "saleorApiUrl" })).rejects.toThrowError(
-      DynamoAppConfigManager.GetConfigDataError,
-    );
+    await expect(
+      manager.get({ appId: "appId", saleorApiUrl: "saleorApiUrl" }),
+    ).rejects.toThrowError(DynamoAppConfigManager.GetConfigDataError);
   });
 
   it("should set App Config in DynamoDB", async () => {
@@ -78,15 +78,15 @@ describe("DynamoAppConfigManager", () => {
     expect(respositoryResult._unsafeUnwrap()).toBe(config);
   });
 
-  it("should throw error if setting App Config fails", () => {
+  it("should throw error if setting App Config fails", async () => {
     const repository = new MemoryConfigRepository();
 
     vi.spyOn(repository, "setAppConfigEntry").mockReturnValue(
       Promise.resolve(err(new DynamoAppConfigManager.SetConfigDataError("Error setting data"))),
     );
     const manager = DynamoAppConfigManager.create(repository);
 
-    expect(
+    await expect(
       manager.set({
         appId: "appId",
         saleorApiUrl: "saleorApiUrl",
diff --git a/apps/smtp/eslint.config.js b/apps/smtp/eslint.config.js
@@ -1,4 +1,21 @@
 import { config } from "@saleor/eslint-config-apps/index.js";
 
 /** @type {import("eslint").Linter.Config} */
-export default config;
+export default [
+  ...config,
+  {
+    // TODO: remove this override once the recommended rules are fixed
+    name: "saleor-app-smtp/override-recommended",
+    files: ["**/*.{ts,tsx}"],
+    rules: {
+      "@typescript-eslint/no-unused-vars": "warn",
+      "@typescript-eslint/no-unused-expressions": "warn",
+      "@typescript-eslint/no-explicit-any": "warn",
+      "@typescript-eslint/no-non-null-asserted-optional-chain": "warn",
+      "@typescript-eslint/ban-ts-comment": "warn",
+      "no-empty": "warn",
+      "@typescript-eslint/no-require-imports": "warn",
+      "no-extra-boolean-cast": "warn",
+    },
+  },
+];
diff --git a/apps/smtp/src/modules/smtp/configuration/smtp-configuration.service.test.ts b/apps/smtp/src/modules/smtp/configuration/smtp-configuration.service.test.ts
@@ -303,7 +303,9 @@ describe("SmtpConfigurationService", function () {
       expect(setConfigMock).toBeCalledWith(validConfig);
 
       // Since data should be cached automatically, no API call should be triggered
-      expect(await service.getConfigurationRoot());
+      const configuration = await service.getConfigurationRoot();
+
+      expect(configuration._unsafeUnwrap()).toStrictEqual(validConfig);
       expect(getConfigMock).toBeCalledTimes(0);
     });
 
@@ -566,9 +568,7 @@ describe("SmtpConfigurationService", function () {
         SmtpConfigurationService.ConfigNotFoundError,
       );
     });
-  });
 
-  describe("deleteConfiguration", () => {
     it("Error should be thrown, when given ID does not exist", async () => {
       const configurator = new SmtpMetadataManager(
         null as unknown as SettingsManager,
diff --git a/apps/smtp/src/modules/smtp/services/email-compiler.test.ts b/apps/smtp/src/modules/smtp/services/email-compiler.test.ts
@@ -17,7 +17,6 @@ const getMjmlTemplate = (injectedValue: string | number) => `<mjml>
 </mjml>`;
 
 describe("EmailCompiler", () => {
-  let templateCompiler = new HandlebarsTemplateCompiler();
   let compiler = new EmailCompiler(
     new HandlebarsTemplateCompiler(),
     new HtmlToTextCompiler(),
diff --git a/packages/eslint-config/index.js b/packages/eslint-config/index.js
@@ -1,3 +1,4 @@
+import eslint from "@eslint/js";
 import nextPlugin from "@next/eslint-plugin-next";
 import saleorPlugin from "@saleor/eslint-plugin-saleor-app";
 import stylisticPlugin from "@stylistic/eslint-plugin";
@@ -11,26 +12,21 @@ import turboPlugin from "eslint-plugin-turbo";
 import globals from "globals";
 import tseslint from "typescript-eslint";
 
-// TODO: add typescript-eslint & eslint/js recommended configs
-
 /** @type {import('eslint').Linter.Config[]} */
 export const config = [
+  eslint.configs.recommended,
+  ...tseslint.configs.recommended,
   {
     name: "@saleor/eslint-config-apps/ignores",
-    ignores: [
-      ".next/**/*",
-      "coverage/**/*",
-      "**/generated/**/*",
-      "lint-staged.config.js",
-      "next-env.d.ts",
-    ],
+    ignores: [".next/**/*", "coverage/**/*", "**/generated/**/*", "next-env.d.ts"],
   },
   {
     name: "@saleor/eslint-config-apps/code-ts",
     files: ["**/*.{ts,tsx}"],
     languageOptions: {
       parser: tseslint.parser,
       parserOptions: {
+        sourceType: "module",
         projectService: true,
         tsconfigRootDir: import.meta.dirname,
       },
@@ -46,6 +42,7 @@ export const config = [
     },
     rules: {
       ...nextPlugin.configs.recommended.rules,
+      ...tseslint.configs.eslintRecommended.rules,
       "max-params": "off",
       "@typescript-eslint/max-params": ["error", { max: 3 }],
       "turbo/no-undeclared-env-vars": "error",
@@ -110,8 +107,7 @@ export const config = [
       "@typescript-eslint": tseslint.plugin,
     },
     rules: {
-      // TODO: migrate all apps / packages to use this rules
-      // ...vitestPlugin.configs.recommended.rules,
+      ...vitestPlugin.configs.recommended.rules,
       "vitest/prefer-strict-equal": "error",
       "vitest/prefer-vi-mocked": "error",
       "@typescript-eslint/no-restricted-imports": [
diff --git a/packages/eslint-config/lint-staged.config.js b/packages/eslint-config/lint-staged.config.js
@@ -5,5 +5,5 @@ import baseConfig from "../../lint-staged.config.js";
  */
 export default {
   ...baseConfig,
-  "*.cjs": ["prettier --write"],
+  "*.js": ["prettier --write"],
 };
diff --git a/packages/eslint-config/package.json b/packages/eslint-config/package.json
@@ -6,8 +6,9 @@
   "type": "module",
   "main": "index.js",
   "devDependencies": {
+    "@eslint/js": "9.23.0",
     "@next/eslint-plugin-next": "15.2.4",
-    "@saleor/eslint-plugin-saleor-app": "0.0.0-pr-20250326080729",
+    "@saleor/eslint-plugin-saleor-app": "0.2.0",
     "@stylistic/eslint-plugin": "4.2.0",
     "@vitest/eslint-plugin": "1.1.38",
     "eslint": "catalog:",
diff --git a/packages/logger/eslint.config.js b/packages/logger/eslint.config.js
@@ -10,4 +10,15 @@ export default [
       "no-console": "off",
     },
   },
+  {
+    // TODO: remove this override once the recommended rules are fixed
+    name: "@saleor/apps-logger/override-recommended",
+    files: ["**/*.{ts,tsx}"],
+    rules: {
+      "no-fallthrough": "warn",
+      "@typescript-eslint/no-unused-vars": "warn",
+      "@typescript-eslint/ban-ts-comment": "warn",
+      "@typescript-eslint/no-wrapper-object-types": "warn",
+    },
+  },
 ];
diff --git a/packages/otel/eslint.config.js b/packages/otel/eslint.config.js
@@ -1,4 +1,14 @@
 import { config } from "@saleor/eslint-config-apps/index.js";
 
 /** @type {import("eslint").Linter.Config} */
-export default config;
+export default [
+  ...config,
+  {
+    // TODO: remove this override once the recommended rules are fixed
+    name: "@saleor/apps-otel/override-recommended",
+    files: ["**/*.{ts,tsx}"],
+    rules: {
+      "@typescript-eslint/no-explicit-any": "warn",
+    },
+  },
+];
diff --git a/packages/react-hook-form-macaw/src/components/Combobox.tsx b/packages/react-hook-form-macaw/src/components/Combobox.tsx
@@ -28,7 +28,7 @@ export function Combobox<TFieldValues extends FieldValues = FieldValues>({
       control={control}
       render={({ field: { value, onChange, ...field }, fieldState: { error } }) => {
         return (
-          // @ts-ignore todo: fix
+          // @ts-expect-error todo: fix
           <$Combobox
             {...rest}
             {...field}
diff --git a/packages/shared/eslint.config.js b/packages/shared/eslint.config.js
@@ -1,4 +1,17 @@
 import { config } from "@saleor/eslint-config-apps/index.js";
 
 /** @type {import("eslint").Linter.Config} */
-export default config;
+export default [
+  ...config,
+  {
+    // TODO: remove this override once the recommended rules are fixed
+    name: "@saleor/apps-shared/override-recommended",
+    files: ["**/*.{ts,tsx}"],
+    rules: {
+      "@typescript-eslint/no-unused-vars": "warn",
+      "@typescript-eslint/no-empty-object-type": "warn",
+      "@typescript-eslint/no-non-null-asserted-optional-chain": "warn",
+      "no-unsafe-optional-chaining": "warn",
+    },
+  },
+];
diff --git a/packages/shared/src/saleor-version-compatibility-validator.test.ts b/packages/shared/src/saleor-version-compatibility-validator.test.ts
diff --git a/packages/trpc/src/context.ts b/packages/trpc/src/context.ts
diff --git a/packages/ui/eslint.config.js b/packages/ui/eslint.config.js
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
