PLTCONN-4903: Refactoring

Author: megan-tran-sp

cmd/connector/conn_delete.go

@@ -22,8 +22,7 @@ func newConnDeleteCmd(client client.Client) *cobra.Command {
 			connectorRef := cmd.Flags().Lookup("id").Value.String()
 			endpoint := cmd.Flags().Lookup("conn-endpoint").Value.String()
 
-			q := map[string]string{}
-			resp, err := client.Delete(cmd.Context(), util.ResourceUrl(endpoint, connectorRef), q)
+			resp, err := client.Delete(cmd.Context(), util.ResourceUrl(endpoint, connectorRef))
 			if err != nil {
 				return err
 			}

cmd/connector/customizer_delete.go

@@ -6,9 +6,10 @@ import (
 	"io"
 	"net/http"
 
+	"github.com/spf13/cobra"
+
 	"github.com/sailpoint-oss/sailpoint-cli/internal/client"
 	"github.com/sailpoint-oss/sailpoint-cli/internal/util"
-	"github.com/spf13/cobra"
 )
 
 func newCustomizerDeleteCmd(client client.Client) *cobra.Command {
@@ -20,8 +21,7 @@ func newCustomizerDeleteCmd(client client.Client) *cobra.Command {
 		RunE: func(cmd *cobra.Command, args []string) error {
 			id := cmd.Flags().Lookup("id").Value.String()
 
-			q := map[string]string{"type": "hard-delete"}
-			resp, err := client.Delete(cmd.Context(), util.ResourceUrl(connectorCustomizersEndpoint, id), q)
+			resp, err := client.Delete(cmd.Context(), util.ResourceUrl(connectorCustomizersEndpoint, id))
 			if err != nil {
 				return err
 			}

internal/client/client.go

@@ -14,7 +14,7 @@ import (
 
 type Client interface {
 	Get(ctx context.Context, url string) (*http.Response, error)
-	Delete(ctx context.Context, url string, params map[string]string) (*http.Response, error)
+	Delete(ctx context.Context, url string) (*http.Response, error)
 	Post(ctx context.Context, url string, contentType string, body io.Reader) (*http.Response, error)
 	Put(ctx context.Context, url string, contentType string, body io.Reader) (*http.Response, error)
 	Patch(ctx context.Context, url string, body io.Reader) (*http.Response, error)
@@ -62,7 +62,7 @@ func (c *SpClient) Get(ctx context.Context, url string) (*http.Response, error)
 	return resp, nil
 }
 
-func (c *SpClient) Delete(ctx context.Context, url string, params map[string]string) (*http.Response, error) {
+func (c *SpClient) Delete(ctx context.Context, url string) (*http.Response, error) {
 	if err := c.ensureAccessToken(ctx); err != nil {
 		return nil, err
 	}
@@ -78,14 +78,6 @@ func (c *SpClient) Delete(ctx context.Context, url string, params map[string]str
 		fmt.Println(string(dbg))
 	}
 
-	if params != nil {
-		q := req.URL.Query()
-		for k, v := range params {
-			q.Add(k, v)
-		}
-		req.URL.RawQuery = q.Encode()
-	}
-
 	resp, err := c.client.Do(req)
 	if err != nil {
 		return nil, err