Merge pull request #15 from furiatti/master

toygar · toygar · commit 6dafdf834ace · 2015-11-21T09:07:00.000+02:00
Remove observer notification only in method deinit
diff --git a/VideoSplash/Source/VideoSplashViewController.swift b/VideoSplash/Source/VideoSplashViewController.swift
@@ -92,7 +92,6 @@ public class VideoSplashViewController: UIViewController {
 
   override public func viewWillDisappear(animated: Bool) {
     super.viewDidDisappear(animated)
-    NSNotificationCenter.defaultCenter().removeObserver(self)
   }
 
   private func setMoviePlayer(url: NSURL){
@@ -140,6 +139,8 @@ public class VideoSplashViewController: UIViewController {
 
   deinit{
 	self.moviePlayer.player?.removeObserver(self, forKeyPath: "status")
+    NSNotificationCenter.defaultCenter().removeObserver(self)
+
   }
 
   // Override in subclass

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,6 @@ public class VideoSplashViewController: UIViewController {`
`92`	`92`
`93`	`93`	`override public func viewWillDisappear(animated: Bool) {`
`94`	`94`	`super.viewDidDisappear(animated)`
`95`		`- NSNotificationCenter.defaultCenter().removeObserver(self)`
`96`	`95`	`}`
`97`	`96`
`98`	`97`	`private func setMoviePlayer(url: NSURL){`
`@@ -140,6 +139,8 @@ public class VideoSplashViewController: UIViewController {`
`140`	`139`
`141`	`140`	`deinit{`
`142`	`141`	`self.moviePlayer.player?.removeObserver(self, forKeyPath: "status")`
	`142`	`+ NSNotificationCenter.defaultCenter().removeObserver(self)`
	`143`	`+`
`143`	`144`	`}`
`144`	`145`
`145`	`146`	`// Override in subclass`