Add tests for data decoder

Author: Uxio0

app/services/data_decoder.py

@@ -1,7 +1,14 @@
 import logging
-from functools import cached_property, lru_cache
-from threading import Lock
-from typing import Any, NotRequired, Sequence, TypedDict, cast
+from functools import cache, cached_property, lru_cache
+from typing import (
+    Any,
+    AsyncGenerator,
+    AsyncIterator,
+    NotRequired,
+    Sequence,
+    TypedDict,
+    cast,
+)
 
 from eth_abi import decode as decode_abi
 from eth_abi.exceptions import DecodingError
@@ -53,18 +60,28 @@ class MultisendDecoded(TypedDict):
     data_decoded: DataDecoded | None
 
 
-mutex = Lock()
+@cache
+def get_data_decoder_service() -> "DataDecoderService":
+    d = DataDecoderService()
+    d.init()
+    return d
 
 
 class DataDecoderService:
     EXEC_TRANSACTION_SELECTOR = HexBytes("0x6a761202")
 
     dummy_w3 = Web3()
 
-    def __init__(self):
+    async def init(self):
+        """
+        Initialize the data decoder service, loading the ABIs from the database and storing the 4byte selectors
+        in memory
+        """
         logger.info("%s: Loading contract ABIs for decoding", self.__class__.__name__)
         self.fn_selectors_with_abis: dict[bytes, ABIFunction] = (
-            self._generate_selectors_with_abis_from_abis(self.get_supported_abis())
+            await self._generate_selectors_with_abis_from_abis(
+                await self.get_supported_abis()
+            )
         )
         logger.info(
             "%s: Contract ABIs for decoding were loaded", self.__class__.__name__
@@ -91,8 +108,8 @@ def _generate_selectors_with_abis_from_abi(
             if fn_abi["type"] == "function"
         }
 
-    def _generate_selectors_with_abis_from_abis(
-        self, abis: Sequence[Sequence[ABIFunction]]
+    async def _generate_selectors_with_abis_from_abis(
+        self, abis: AsyncIterator[Sequence[ABIFunction]]
     ) -> dict[bytes, ABIFunction]:
         """
         :param abis: Contract ABIs. Last ABIs on the Sequence have preference if there's a collision on the
@@ -101,13 +118,13 @@ def _generate_selectors_with_abis_from_abis(
         """
         return {
             fn_selector: fn_abi
-            for supported_abi in abis
+            async for supported_abi in abis
             for fn_selector, fn_abi in self._generate_selectors_with_abis_from_abi(
                 supported_abi
             ).items()
         }
 
-    async def get_supported_abis(self) -> Sequence[ABIFunction]:
+    async def get_supported_abis(self) -> AsyncIterator[Sequence[ABIFunction]]:
         """
         :return: Every ABI in the database
         """

app/tests/services/test_data_decoder.py

@@ -1,14 +1,9 @@
-import unittest
-
 from ...services.data_decoder import DataDecoderService
+from ..db.db_async_conn import DbAsyncConn
 
 
-class TestRouterAbout(unittest.TestCase):
-    @classmethod
-    def setUpClass(cls):
-        cls.data_decoder = DataDecoderService()
-
-    def test_view_about(self):
-        response = self.client.get("/api/v1/about")
-        self.assertEqual(response.status_code, 200)
-        self.assertEqual(response.json(), {"version": VERSION})
+class TestDataDecoderService(DbAsyncConn):
+    async def test_init(self):
+        d = DataDecoderService()
+        await d.init()
+        assert d.fn_selectors_with_abis == {}

requirements/dev.txt

@@ -5,3 +5,4 @@ httpx
 mypy
 pre-commit
 pytest
+pytest-asyncio