Skip to content

addSignature doesn't checksum addresses #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
katspaugh opened this issue Jul 28, 2023 · 0 comments
Open

addSignature doesn't checksum addresses #495

katspaugh opened this issue Jul 28, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@katspaugh
Copy link
Member

katspaugh commented Jul 28, 2023 •
edited
Loading

Keys in the signatures Map are lower-case, non-checksummed, addresses.

This is problematic when checking if a transaction is signed by a specific owner via a checksummed address:

safeTransaction.signatures.has(checksummedOwnerAddress) // false
safeTransaction.signatures.has(checksummedOwnerAddress.toLowerCase()) // true

Alternatively, the SDK could export a method like isSignedBy:

safeTransaction.isSignedBy(address) // doesn't matter if address is checksummed or not
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@katspaugh