Skip to content

Add depositAndPause function #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
andreivladbrg opened this issue Apr 30, 2024 · 8 comments · Fixed by #134
Closed
1 task done

Add depositAndPause function #59

andreivladbrg opened this issue Apr 30, 2024 · 8 comments · Fixed by #134
Assignees
Labels
effort: medium Default level of effort. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@andreivladbrg
Copy link
Member

andreivladbrg commented Apr 30, 2024

Ref #58 and #92 (comment)

Depends on

@andreivladbrg

This comment was marked as outdated.

@smol-ninja

This comment was marked as outdated.

@andreivladbrg andreivladbrg added priority: 1 This is important. It should be dealt with shortly. effort: medium Default level of effort. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels May 16, 2024
@andreivladbrg

This comment was marked as resolved.

@smol-ninja smol-ninja self-assigned this May 16, 2024
@smol-ninja smol-ninja added the type: feature New feature or request. label May 16, 2024
@andreivladbrg
Copy link
Member Author

andreivladbrg commented May 17, 2024

for the simplicity of this function, the implementation can call deposit and then pause:

function depositAndPause(uint256 streamId) external {
     uint128  debt = streamDebtOf(streamId);
     deposit(streamId, debt);
     pause(streamId);
}

@smol-ninja

This comment was marked as outdated.

@smol-ninja smol-ninja closed this as not planned Won't fix, can't repro, duplicate, stale May 20, 2024
@smol-ninja smol-ninja changed the title Add payDebtAndCancelStream function Add payDebtAndPause function May 20, 2024
@smol-ninja

This comment was marked as outdated.

@smol-ninja smol-ninja reopened this May 20, 2024
@andreivladbrg

This comment was marked as outdated.

@smol-ninja smol-ninja changed the title Add payDebtAndPause function Add depositAndPause function May 21, 2024
@smol-ninja

This comment was marked as resolved.

@smol-ninja smol-ninja changed the title Add depositAndPause function Add depositAndPause function May 21, 2024
@smol-ninja smol-ninja assigned smol-ninja and unassigned smol-ninja May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium Default level of effort. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants