Should we remove SablierV2OpenEnded
prefix from error names?
#51
Replies: 3 comments
-
I will apply the same argument from here: #49 (comment) It makes debugging easier and it improves the DX. Also tagging @PaulRBerg as he is the one who introduces this method of writing custom errors. |
Beta Was this translation helpful? Give feedback.
-
Errors are there not for us internally, but for the external world. It makes most sense to keep using the contract name as a prefix: https://twitter.com/PaulRBerg/status/1510584043028500492
Feature, not bug |
Beta Was this translation helpful? Give feedback.
-
Thank you both for your comments. I agree and we can close this. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Motivation
SablierV2OpenEnded
contract.SablierV2OpenEnded
makes them longer to read.Beta Was this translation helpful? Give feedback.
All reactions