Can't we remove the remappings file?

[PaulRBerg]

Do we still need this? @sablier-labs/evm

https://github.com/sablier-labs/flow/blob/ba0d774eeb6827e5109ae790407cdc69431e0fa6/remappings.txt

[andreivladbrg]

hmm, is the compiler able to figure it out the import paths? i.e. we sholdn't do this?

import { ERC721 } from "node_modules/@openzeppelin/contracts/token/ERC721/ERC721.sol";

[smol-ninja]

What are you proposing @PaulRBerg? remappings make imports look beautiful.

[PaulRBerg]

Nevermind, I forgot that we need them for the compiler

[smol-ninja]

Can you please explain why we need it for the compiler? The above example from Andrei's comment would be compiled too.

[PaulRBerg]

See my comment below.

[PaulRBerg]

It looks like the code compiles without remappings.txt — and we don't need to add the node_modules prefix.

https://github.com/sablier-labs/lockup/tree/experiment/remove-remappings

Though maybe we need the remappings for users who install the Sablier repos using git submodules? Can you look into this?

[smol-ninja]

Yes, its working even when dependents have no remappings.txt.

[andreivladbrg]

That's very interesting — that wasn't the behavior a while ago. I couldn't find the implementation of this feature (figuring out the remappings in node_modules) in the Foundry repo.

Well, in that case, there's no need to keep remappings.txt anymore.

Note: we should update the README as well (e.g. here).

[PaulRBerg]

@smol-ninja I meant if it's working when we don't provide a remappings.txtfile, not if the dependents don't have their own file

[smol-ninja]

I tested a version where lockup does not have remappings.txt and then I setup a new project that uses submodules to install this lockup version without remappings.txt. It worked but I had to define remappings.txt in the new project. Because the lockup deps would be inside lib/lockup/node_modules and the project repo wasn’t able to resolve that.

[PaulRBerg]

Great, in that case, let's nuke out of orbit all remappings.txt file.