Merge bitcoin-core#78: refactor: Do not shadow InvokeContext::connection member

ryanofsky · ryanofsky · commit ddd2cee62751 · 2022-09-19T13:46:18.000-04:00
f999694 refactor: Do not shadow `InvokeContext::connection` member (Hennadii Stepanov) Pull request description: Fixes `-Wshadow-field` warning. Closes bitcoin-core#77. ACKs for top commit: ryanofsky: Code review ACK f999694 Tree-SHA512: b464d4018d0474d5797cbf711f375d65dcf417fa31da30b60af47337f4faa4bcaa31c01c16b18277efd0e83c105ba620131c424cf130ce831c1c2861b6c627ca
diff --git a/include/mp/proxy-io.h b/include/mp/proxy-io.h
@@ -30,8 +30,8 @@ struct InvokeContext
 struct ClientInvokeContext : InvokeContext
 {
     ThreadContext& thread_context;
-    ClientInvokeContext(Connection& connection, ThreadContext& thread_context)
-        : InvokeContext{connection}, thread_context{thread_context}
+    ClientInvokeContext(Connection& conn, ThreadContext& thread_context)
+        : InvokeContext{conn}, thread_context{thread_context}
     {
     }
 };

Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,8 @@ struct InvokeContext`
`30`	`30`	`struct ClientInvokeContext : InvokeContext`
`31`	`31`	`{`
`32`	`32`	`ThreadContext& thread_context;`
`33`		`- ClientInvokeContext(Connection& connection, ThreadContext& thread_context)`
`34`		`- : InvokeContext{connection}, thread_context{thread_context}`
	`33`	`+ ClientInvokeContext(Connection& conn, ThreadContext& thread_context)`
	`34`	`+ : InvokeContext{conn}, thread_context{thread_context}`
`35`	`35`	`{`
`36`	`36`	`}`
`37`	`37`	`};`