Skip to content

Commit 32e52ca

Browse files
authored
Merge pull request #1423 from ArhanChaudhary/docs-elaboration
Be more explicit with available wasm-opt flags in documentation
2 parents ba5fef3 + 6f33393 commit 32e52ca

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

docs/src/cargo-toml-configuration.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@ The available configuration options and their default values are shown below:
1818
# be set to an array of strings which are explicit arguments to pass to
1919
# `wasm-opt`. For example `['-Os']` would optimize for size while `['-O4']`
2020
# would execute very expensive optimizations passes
21+
#
22+
# In most cases, the `-O[X]` flag is enough. However, if you require extreme
23+
# optimizations, see the full list of `wasm-opt` optimization flags
24+
# https://github.com/WebAssembly/binaryen/blob/version_117/test/lit/help/wasm-opt.test
2125
wasm-opt = ['-O']
2226

2327
[package.metadata.wasm-pack.profile.dev.wasm-bindgen]

src/install/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ pub fn prebuilt_url_for(tool: &Tool, version: &str, arch: &Arch, os: &Os) -> Res
203203
Tool::WasmOpt => {
204204
Ok(format!(
205205
"https://github.com/WebAssembly/binaryen/releases/download/{vers}/binaryen-{vers}-{target}.tar.gz",
206-
vers = "version_117",
206+
vers = "version_117", // Make sure to update the version in docs/src/cargo-toml-configuration.md as well
207207
target = target,
208208
))
209209
}

0 commit comments

Comments
 (0)