Move lints to workspace (#4294)

Author: daxpedda

.cargo/config.toml

@@ -1,15 +1,2 @@
 [target.'cfg(target_arch = "wasm32")']
 runner = 'cargo run -p wasm-bindgen-cli --bin wasm-bindgen-test-runner --'
-
-[target.'cfg(all())']
-rustflags = [
-  "-Adead_code",
-  "-Anon_upper_case_globals",
-  "-Aunused_doc_comments",
-  "-Aclippy::large_enum_variant",
-  "-Aclippy::missing_safety_doc",
-  "-Aclippy::new_without_default",
-  "-Aclippy::overly_complex_bool_expr",
-  "-Aclippy::too_many_arguments",
-  "-Aclippy::type_complexity",
-]

.github/workflows/main.yml

@@ -62,6 +62,7 @@ jobs:
     - run: rustup update --no-self-update stable && rustup default stable
     - run: rustup target add wasm32-unknown-unknown
     - run: cargo clippy --no-deps --all-features -p wasm-bindgen-backend -- -D warnings
+    - run: cargo clippy --no-deps --all-features -p wasm-bindgen -- -D warnings
     - run: cargo clippy --no-deps --all-features -p wasm-bindgen-cli -- -D warnings
     - run: cargo clippy --no-deps --all-features -p wasm-bindgen-cli-support -- -D warnings
     - run: cargo clippy --no-deps --all-features -p example-tests -- -D warnings
@@ -89,8 +90,8 @@ jobs:
     - uses: actions/checkout@v4
     - run: rustup update --no-self-update stable && rustup default stable
     - run: rustup target add wasm32-unknown-unknown
-    - run: cargo clippy --no-deps --all-features --target wasm32-unknown-unknown -p js-sys -- -D warnings
-    - run: cargo clippy --no-deps --all-features --target wasm32-unknown-unknown -p web-sys -- -D warnings
+    - run: cargo clippy --no-deps --all-features --target wasm32-unknown-unknown -p js-sys --all-targets -- -D warnings
+    - run: cargo clippy --no-deps --all-features --target wasm32-unknown-unknown -p web-sys --all-targets -- -D warnings
 
   # Run `cargo clippy` over crates that support `no_std`
   clippy_no_std:
@@ -111,7 +112,7 @@ jobs:
     name: Clippy `no_std` with `atomics`
     runs-on: ubuntu-latest
     env:
-      CARGO_TARGET_WASM32_UNKNOWN_UNKNOWN_RUSTFLAGS: -Ctarget-feature=+atomics,+bulk-memory
+      RUSTFLAGS: -Ctarget-feature=+atomics,+bulk-memory
     steps:
     - uses: actions/checkout@v4
     - run: rustup default nightly-2024-07-06

Cargo.toml

@@ -70,6 +70,20 @@ wasm-bindgen-test-crate-b = { path = 'tests/crates/b' }
 [lints.rust]
 unexpected_cfgs = { level = "warn", check-cfg = ['cfg(wasm_bindgen_unstable_test_coverage)'] }
 
+[lints.clippy]
+large_enum_variant = "allow"
+new_without_default = "allow"
+overly_complex_bool_expr = "allow"
+too_many_arguments = "allow"
+type_complexity = "allow"
+
+[workspace.lints.clippy]
+large_enum_variant = "allow"
+new_without_default = "allow"
+overly_complex_bool_expr = "allow"
+too_many_arguments = "allow"
+type_complexity = "allow"
+
 [workspace]
 exclude = ["crates/msrv"]
 members = [

crates/backend/Cargo.toml

@@ -29,3 +29,6 @@ proc-macro2 = "1.0"
 quote = '1.0'
 syn = { version = '2.0', features = ['full'] }
 wasm-bindgen-shared = { path = "../shared", version = "=0.2.95" }
+
+[lints]
+workspace = true

crates/cli-support/Cargo.toml

@@ -29,3 +29,6 @@ wasm-bindgen-shared = { path = "../shared", version = '=0.2.95' }
 wasm-bindgen-threads-xform = { path = '../threads-xform', version = '=0.2.95' }
 wasm-bindgen-wasm-conventions = { path = '../wasm-conventions', version = '=0.2.95' }
 wasm-bindgen-wasm-interpreter = { path = "../wasm-interpreter", version = '=0.2.95' }
+
+[lints]
+workspace = true

crates/cli-support/src/lib.rs

@@ -812,13 +812,3 @@ where
     pairs.sort_by_key(|(k, _)| *k);
     pairs.into_iter()
 }
-
-/// Like `sorted_iter`, but produces mutable references to the values
-fn sorted_iter_mut<K, V>(map: &mut HashMap<K, V>) -> impl Iterator<Item = (&K, &mut V)>
-where
-    K: Ord,
-{
-    let mut pairs = map.iter_mut().collect::<Vec<_>>();
-    pairs.sort_by_key(|(k, _)| *k);
-    pairs.into_iter()
-}

crates/cli-support/src/wit/nonstandard.rs

@@ -244,6 +244,7 @@ pub enum AuxImport {
         mutable: bool,      // whether or not this was a `FnMut` closure
         dtor: u32,          // table element index of the destructor function
         adapter: AdapterId, // the adapter which translates the types for this closure
+        #[allow(dead_code)]
         nargs: usize,
     },
 

crates/cli-support/src/wit/standard.rs

@@ -40,6 +40,7 @@ pub enum AdapterKind {
         instructions: Vec<InstructionData>,
     },
     Import {
+        #[allow(dead_code)]
         module: String,
         name: String,
         kind: AdapterJsImportKind,
@@ -139,10 +140,12 @@ pub enum Instruction {
     /// Pops a typed integer (`u8`, `s16`, etc.) and pushes a plain Wasm `i32` or `i64` equivalent.
     IntToWasm {
         input: AdapterType,
+        #[allow(dead_code)]
         output: walrus::ValType,
     },
     /// Pops a Wasm `i32` or `i64` and pushes a typed integer (`u8`, `s16`, etc.) equivalent.
     WasmToInt {
+        #[allow(dead_code)]
         input: walrus::ValType,
         output: AdapterType,
     },
@@ -166,6 +169,7 @@ pub enum Instruction {
 
     OptionWasmToStringEnum {
         name: String,
+        #[allow(dead_code)]
         hole: u32,
     },
 
@@ -310,6 +314,7 @@ pub enum Instruction {
     /// pops ptr/length i32, loads string from cache
     CachedStringLoad {
         owned: bool,
+        #[allow(dead_code)]
         optional: bool,
         mem: walrus::MemoryId,
         free: walrus::FunctionId,

crates/cli/Cargo.toml

@@ -57,3 +57,6 @@ rustls-tls = ["ureq/tls"]
 # Legacy support
 openssl = ["dep:native-tls"]
 vendored-openssl = ["openssl", "native-tls/vendored"]
+
+[lints]
+workspace = true

crates/externref-xform/Cargo.toml

@@ -24,6 +24,9 @@ wasmprinter = "0.214"
 wast = "214"
 wat = "1.0"
 
+[lints]
+workspace = true
+
 [[test]]
 harness = false
 name = "all"