Revert "Allow using 'static lifetimes in functions (#3856)" (#3865)

Author: daxpedda

CHANGELOG.md

@@ -21,11 +21,6 @@
 * Allow overriding the URL used for headless tests by setting `WASM_BINDGEN_TEST_ADDRESS`.
   [#3861](https://github.com/rustwasm/wasm-bindgen/pull/3861)
 
-### Changed
-
-* Allow using `'static` lifetimes in functions marked with `#[wasm_bindgen]`. This does not allow references where they were not allowed before!
-  [#3856](https://github.com/rustwasm/wasm-bindgen/pull/3856)
-
 ### Fixed
 
 * Make .wasm output deterministic when using `--reference-types`.

crates/macro-support/src/parser.rs

@@ -1652,14 +1652,12 @@ fn assert_no_lifetimes(sig: &syn::Signature) -> Result<(), Diagnostic> {
     }
 
     impl<'ast> syn::visit::Visit<'ast> for Walk {
-        fn visit_lifetime(&mut self, lifetime: &'ast syn::Lifetime) {
-            if lifetime.ident != "static" {
-                self.diagnostics.push(err_span!(
-                    lifetime,
-                    "it is currently not sound to use lifetimes in function \
+        fn visit_lifetime(&mut self, i: &'ast syn::Lifetime) {
+            self.diagnostics.push(err_span!(
+                i,
+                "it is currently not sound to use lifetimes in function \
                  signatures"
-                ));
-            }
+            ));
         }
     }
     let mut walk = Walk {

crates/macro/ui-tests/invalid-imports-1.rs

@@ -36,8 +36,6 @@ extern "C" {
     fn f() -> Result<>;
     #[wasm_bindgen(catch)]
     fn f() -> Result<'a>;
-    #[wasm_bindgen(catch)]
-    fn f() -> Result<&'static u32>;
 }
 
 fn main() {}

crates/macro/ui-tests/invalid-imports-1.stderr

@@ -1,3 +1,9 @@
+error: it is currently not sound to use lifetimes in function signatures
+ --> ui-tests/invalid-imports.rs:7:16
+  |
+7 |     fn f() -> &'static u32;
+  |                ^^^^^^^
+
 error: imported methods must have at least one argument
   --> ui-tests/invalid-imports.rs:10:5
    |