Skip to content

Commit 624ff42

Browse files
silvanshadealexcrichton
authored andcommitted
Mark js_sys::Promise as #[must_use] (#1927)
* Mark js_sys::Promise as #[must_use] * Fix js_sys::Promise #[must_use] warnings
1 parent 7ed1522 commit 624ff42

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

crates/futures/src/lib.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ impl From<Promise> for JsFuture {
158158
Closure::once(move |val| finish(&state, Err(val)))
159159
};
160160

161-
js.then2(&resolve, &reject);
161+
let _ = js.then2(&resolve, &reject);
162162

163163
state.borrow_mut().callbacks = Some((resolve, reject));
164164

crates/futures/src/queue.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ impl Queue {
5656
// eventually we should probably use something like `queueMicrotask`:
5757
// https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/queueMicrotask
5858
if !self.state.is_spinning.replace(true) {
59-
self.promise.then(&self.closure);
59+
let _ = self.promise.then(&self.closure);
6060
}
6161
}
6262
}

crates/js-sys/src/lib.rs

+1
Original file line numberDiff line numberDiff line change
@@ -4567,6 +4567,7 @@ extern "C" {
45674567
/// an asynchronous operation, and its resulting value.
45684568
///
45694569
/// [MDN documentation](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise)
4570+
#[must_use]
45704571
#[wasm_bindgen(extends = Object)]
45714572
#[derive(Clone, Debug)]
45724573
pub type Promise;

0 commit comments

Comments
 (0)