WIP assert_no_shims on more signatures

Author: fitzgen

Cargo.toml

@@ -90,3 +90,6 @@ wasm-bindgen = { path = '.' }
 wasm-bindgen-futures = { path = 'crates/futures' }
 js-sys = { path = 'crates/js-sys' }
 web-sys = { path = 'crates/web-sys' }
+
+# TODO FITZGEN
+wasm-webidl-bindings = { path = '../wasm-webidl-bindings' }

crates/cli-support/src/js/mod.rs

@@ -2001,7 +2001,8 @@ impl<'a> Context<'a> {
                 if assert_no_shim {
                     panic!(
                         "imported function was annotated with `#[wasm_bindgen(assert_no_shim)]` \
-                         but we need to generate a JS shim for it"
+                         but we need to generate a JS shim for it: {:?}",
+                        import,
                     );
                 }
 

tests/wasm/no_shims.rs

@@ -33,6 +33,12 @@ use wasm_bindgen_test::*;
         assert_eq(v, 'hello');
         return v;
     };
+
+    module.exports.MyNamespace = {};
+    module.exports.MyNamespace.incoming_namespaced = function () { return 3.14; };
+    module.exports.MyNamespace.outgoing_namespaced = function (pi) { assert_eq(3.14, pi); };
+
+    module.exports.incoming_bool = function () { return true; };
 ")]
 extern "C" {
     #[wasm_bindgen(assert_no_shim)]
@@ -55,6 +61,14 @@ extern "C" {
     #[wasm_bindgen(assert_no_shim)]
     fn many(x: i32, y: f32, z: f64) -> i32;
 
+    #[wasm_bindgen(assert_no_shim, js_namespace = MyNamespace)]
+    fn incoming_namespaced() -> f64;
+    #[wasm_bindgen(assert_no_shim, js_namespace = MyNamespace)]
+    fn outgoing_namespaced(x: f64);
+
+    #[wasm_bindgen(assert_no_shim)]
+    fn incoming_bool() -> bool;
+
     // Note that this should only skip the JS shim if we have anyref support
     // enabled.
     //
@@ -80,6 +94,13 @@ fn no_shims() {
     let w = many(x, y, z);
     assert_eq!(w, 42);
 
+    let pi = incoming_namespaced();
+    assert_eq!(pi, 3.14);
+    outgoing_namespaced(pi);
+
+    let b = incoming_bool();
+    assert!(b);
+
     let v = JsValue::from("hello");
     let vv = works_when_anyref_support_is_enabled(v.clone());
     assert_eq!(v, vv);