Skip to content

Commit f95fba5

Browse files
committed
Auto merge of #136160 - ShE3py:should-panic-backticks, r=<try>
Remove backticks from `ShouldPanic::YesWithMessage`'s `TrFailedMsg` More legible imo ```rs #[test] #[should_panic = "love"] fn foo() { assert!(1 == 2); } ``` Before: ``` note: panic did not contain expected string panic message: `"assertion failed: 1 == 2"`, expected substring: `"love"` ``` After: ``` note: panic did not contain expected string panic message: "assertion failed: 1 == 2" expected substring: "love" ``` Also removed the comma as `assert_eq!` / `assert_ne!` don't use one. `@rustbot` label +A-libtest
2 parents 75530e9 + afb78f0 commit f95fba5

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

library/test/src/test_result.rs

+4-5
Original file line numberDiff line numberDiff line change
@@ -58,16 +58,15 @@ pub(crate) fn calc_result<'a>(
5858
} else if let Some(panic_str) = maybe_panic_str {
5959
TestResult::TrFailedMsg(format!(
6060
r#"panic did not contain expected string
61-
panic message: `{panic_str:?}`,
62-
expected substring: `{msg:?}`"#
61+
panic message: {panic_str:?}
62+
expected substring: {msg:?}"#
6363
))
6464
} else {
6565
TestResult::TrFailedMsg(format!(
6666
r#"expected panic with string value,
6767
found non-string value: `{:?}`
68-
expected substring: `{:?}`"#,
69-
(*err).type_id(),
70-
msg
68+
expected substring: {msg:?}"#,
69+
(*err).type_id()
7170
))
7271
}
7372
}

library/test/src/tests.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -200,8 +200,8 @@ fn test_should_panic_bad_message() {
200200
}
201201
let expected = "foobar";
202202
let failed_msg = r#"panic did not contain expected string
203-
panic message: `"an error message"`,
204-
expected substring: `"foobar"`"#;
203+
panic message: "an error message"
204+
expected substring: "foobar""#;
205205
let desc = TestDescAndFn {
206206
desc: TestDesc {
207207
name: StaticTestName("whatever"),
@@ -238,7 +238,7 @@ fn test_should_panic_non_string_message_type() {
238238
let failed_msg = format!(
239239
r#"expected panic with string value,
240240
found non-string value: `{:?}`
241-
expected substring: `"foobar"`"#,
241+
expected substring: "foobar""#,
242242
TypeId::of::<i32>()
243243
);
244244
let desc = TestDescAndFn {

0 commit comments

Comments
 (0)