Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat code with rustfmt #563

Closed
anatol opened this issue Mar 31, 2017 · 5 comments
Closed

Reformat code with rustfmt #563

anatol opened this issue Mar 31, 2017 · 5 comments
Labels
A-CI Area: CI-related items

Comments

@anatol
Copy link
Contributor

anatol commented Mar 31, 2017

Keeping consistent code formatting across Rust projects is a great thing that simplifies learning new projects and getting familiar with its codebase. rustfmt is a standard tool that tries to achieve it. It would be really great if Rust developers use rustfmt for the core projects like libc.

@kristate
Copy link
Contributor

@anatol Thanks for your suggestion! libc currently has a CI script for style validation (ci/style.rs), but perhaps you would like to improve upon it?

@gnzlbg gnzlbg added the A-CI Area: CI-related items label Nov 22, 2018
@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 27, 2018

This has been done already, but I'm leaving this open because we are not currently blocking commits on being properly formatted with rustfmt yet.

@gnzlbg
Copy link
Contributor

gnzlbg commented Feb 21, 2019

This is blocked on: rust-lang/rustfmt#3253

@kellda
Copy link
Contributor

kellda commented Jul 24, 2020

Now rust-lang/rustfmt#3253 is closed and (when available) rustfmt is run on CI in ci/style.sh.

Is this issue solved ? Or should we ensure that rustfmt is always run (by using stable or a nightly with rustfmt) ?

@JohnTitor
Copy link
Member

Closing as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: CI-related items
Projects
None yet
Development

No branches or pull requests

5 participants