Skip to content

Commit 23c36f5

Browse files
committed
Auto merge of #14704 - Muscraft:fix-renovate, r=weihanglo
fix(renovate): Switch matchPackageNames to matchDepNames When talking to `@weihanglo` about #14703, it was noticed that `renovate` was ignoring `extractVersion` and `schedule` for [`MSRV:1`](https://github.com/rust-lang/cargo/blob/cf53cc54bb593b5ec3dc2be4b1702f50c36d24d5/.github/renovate.json5#L50-L53) and [`MSRV:3`](https://github.com/rust-lang/cargo/blob/cf53cc54bb593b5ec3dc2be4b1702f50c36d24d5/.github/renovate.json5#L64-L67). After a lot of digging into why that was happening, I figured out that it was caused by a [breaking change in `renovate@38`](https://github.com/renovatebot/renovate/releases/tag/38.0.0): > **package-rules**: `matchPackageNames` and related functions no longer fall back to checking `depName`. This change caused `renovate` to no longer apply the configuration from `packageRules` to `MSRV:1` and `MSRV:3` as the `customManagers` for both specified [`depNameTemplate`](https://github.com/rust-lang/cargo/blob/cf53cc54bb593b5ec3dc2be4b1702f50c36d24d5/.github/renovate.json5#L23) which is no longer being read. To fix this issue, I changed `matchPackageNames` to `matchDepNames`, which solved the issue when I was testing locally.
2 parents cf53cc5 + 449d6cb commit 23c36f5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/renovate.json5

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
matchManagers: [
4545
'custom.regex',
4646
],
47-
matchPackageNames: [
47+
matchDepNames: [
4848
'MSRV:1',
4949
],
5050
extractVersion: '^(?<version>\\d+\\.\\d+)', // Drop the patch version
@@ -58,7 +58,7 @@
5858
matchManagers: [
5959
'custom.regex',
6060
],
61-
matchPackageNames: [
61+
matchDepNames: [
6262
'MSRV:3',
6363
],
6464
extractVersion: '^(?<version>\\d+\\.\\d+)', // Drop the patch version

0 commit comments

Comments
 (0)