Skip to content

build(deps): Bump github.com/containerd/nerdctl/v2 from 2.0.3 to 2.0.4 #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

coderbirju
Copy link
Contributor

Issue #, if available:

Description of changes:

Testing done:

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coderbirju coderbirju force-pushed the upgrade-nerdctl204 branch from e0489b4 to bb88893 Compare April 2, 2025 19:50
@coderbirju coderbirju marked this pull request as ready for review April 2, 2025 19:56
@coderbirju coderbirju changed the title chore: upgrade nerdctl version-2.0.4 build(deps): Bump github.com/containerd/nerdctl/v2 from 2.0.3 to 2.0.4 Apr 2, 2025
@swagatbora90
Copy link
Contributor

We should also update our test environment to run against the latest version of nerdctl. Some of the tests rely on nerdctl cli directly

NERDCTL_VERSION=2.0.0

@coderbirju coderbirju force-pushed the upgrade-nerdctl204 branch from bb88893 to ecc8ea1 Compare April 2, 2025 20:24
pendo324
pendo324 previously approved these changes Apr 2, 2025
@pendo324
Copy link
Member

pendo324 commented Apr 2, 2025

Your e2e tests may end up hitting this same error: #206

swagatbora90
swagatbora90 previously approved these changes Apr 2, 2025
@coderbirju
Copy link
Contributor Author

Your e2e tests may end up hitting this same error: #206

Seems like I'm hitting the same error, will wait for that PR to get merged

@pendo324
Copy link
Member

pendo324 commented Apr 2, 2025

Your e2e tests may end up hitting this same error: #206

Seems like I'm hitting the same error, will wait for that PR to get merged

Merged!

Signed-off-by: Arjun Raja Yogidas <[email protected]>
@coderbirju coderbirju dismissed stale reviews from swagatbora90 and pendo324 via fc2cabc April 2, 2025 21:03
@coderbirju coderbirju force-pushed the upgrade-nerdctl204 branch from ecc8ea1 to fc2cabc Compare April 2, 2025 21:03
@swagatbora90 swagatbora90 merged commit f285fcd into runfinch:main Apr 2, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants