Is that good enough memoization?

Author: Edvard Makhlin

server/events/vcs/bitbucketcloud/client.go

@@ -40,6 +40,8 @@ func NewClient(httpClient *http.Client, username string, password string, atlant
 	}
 }
 
+var MY_UUID = ""
+
 // GetModifiedFiles returns the names of files that were modified in the merge request
 // relative to the repo root, e.g. parent/child/file.txt.
 func (b *Client) GetModifiedFiles(logger logging.SimpleLogging, repo models.Repo, pull models.PullRequest) ([]string, error) {
@@ -134,7 +136,10 @@ func (b *Client) HidePrevCommandComments(logger logging.SimpleLogging, repo mode
 			if strings.Contains(firstLine, strings.ToLower(command)) {
 				// we found our old comment that references that command
 				logger.Debug("Deleting comment with id %s", *c.ID)
-				b.DeletePullRequestComment(repo, pullNum, *c.ID)
+				err = b.DeletePullRequestComment(repo, pullNum, *c.ID)
+				if err != nil {
+					return err
+				}
 			}
 		}
 	}
@@ -165,25 +170,30 @@ func (b *Client) GetPullRequestComments(repo models.Repo, pullNum int) (comments
 }
 
 func (b *Client) GetMyUUID() (uuid string, err error) {
-	path := fmt.Sprintf("%s/2.0/user", b.BaseURL)
-	resp, err := b.makeRequest("GET", path, nil)
+	if MY_UUID == "" {
+		path := fmt.Sprintf("%s/2.0/user", b.BaseURL)
+		resp, err := b.makeRequest("GET", path, nil)
 
-	if err != nil {
-		return uuid, err
-	}
+		if err != nil {
+			return uuid, err
+		}
 
-	var user User
-	if err := json.Unmarshal(resp, &user); err != nil {
-		return uuid, errors.Wrapf(err, "Could not parse response %q", string(resp))
-	}
+		var user User
+		if err := json.Unmarshal(resp, &user); err != nil {
+			return uuid, errors.Wrapf(err, "Could not parse response %q", string(resp))
+		}
 
-	if err := validator.New().Struct(user); err != nil {
-		return uuid, errors.Wrapf(err, "API response %q was missing a field", string(resp))
-	}
+		if err := validator.New().Struct(user); err != nil {
+			return uuid, errors.Wrapf(err, "API response %q was missing a field", string(resp))
+		}
 
-	uuid = *user.UUID
-	return uuid, nil
+		uuid = *user.UUID
+		MY_UUID = uuid
 
+		return uuid, nil
+	} else {
+		return MY_UUID, nil
+	}
 }
 
 // PullIsApproved returns true if the merge request was approved.

server/events/vcs/bitbucketcloud/client_test.go

@@ -374,7 +374,7 @@ func TestClient_GetMyUUID(t *testing.T) {
 	testServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		switch r.RequestURI {
 		case "/2.0/user":
-			w.Write([]byte(json)) // nolint: errcheck
+			w.Write(json) // nolint: errcheck
 			return
 		default:
 			t.Errorf("got unexpected request at %q", r.RequestURI)
@@ -397,7 +397,7 @@ func TestClient_GetComment(t *testing.T) {
 	testServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		switch r.RequestURI {
 		case "/2.0/repositories/myorg/myrepo/pullrequests/5/comments":
-			w.Write([]byte(json)) // nolint: errcheck
+			w.Write(json) // nolint: errcheck
 			return
 		default:
 			t.Errorf("got unexpected request at %q", r.RequestURI)
@@ -472,7 +472,7 @@ func TestClient_HidePRComments(t *testing.T) {
 		// we have two comments in the test file
 		// The code is going to delete them all and then create a new one
 		case "/2.0/repositories/myorg/myrepo/pullrequests/5/comments/498931882":
-			w.Write([]byte(""))
+			w.Write([]byte("")) // nolint: errcheck
 			called += 1
 			return
 			// This is the second one
@@ -484,10 +484,10 @@ func TestClient_HidePRComments(t *testing.T) {
 			Assert(t, r.Method != "DELETE", "Shouldn't delete this one")
 			return
 		case "/2.0/repositories/myorg/myrepo/pullrequests/5/comments":
-			w.Write([]byte(comments)) // nolint: errcheck
+			w.Write(comments) // nolint: errcheck
 			return
 		case "/2.0/user":
-			w.Write([]byte(json)) // nolint: errcheck
+			w.Write(json) // nolint: errcheck
 			return
 		default:
 			t.Errorf("got unexpected request at %q", r.RequestURI)
@@ -514,4 +514,3 @@ func TestClient_HidePRComments(t *testing.T) {
 	Ok(t, err)
 	Equals(t, 2, called)
 }
-